This repository was archived by the owner on Dec 18, 2024. It is now read-only.
fix(stack-blitz): add more configuration files to the template #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI is failing due to However, the e2e and unit tests pass locally. |
allow the exported/downloaded project from StackBlitz to be functional - move files into /src and /src/app to match a normal configuration rename Stackblitz to StackBlitz use StackBlitz logo to launch examples use a relative URL for downloading `versions.json` update Ivy fix for VersionPicker log errors during app bootstrap in StackBlitz switch StackBlitz examples to SCSS fix lint warnings in deploy script add ignores for Firebase Fixes #623. Fixes #629. Relates to #642.
Splaktar
force-pushed
the
stackblitz-ivy
branch
from
ee97960 to
790106e
Compare
|
CI fixed and passing. |
This was referenced Oct 6, 2019
Merged
|
@Splaktar looks like this needs rebase on top of your other PR |
|
@jelbourn The other one included all of these changes. It was marked blocked as this one needed to be merged first. But that's no problem. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
What is the current behavior?
StackBlitz is currently broken in
masterdue to some changes in #642 not being fully tested after deployment to the dev instance.Issue Number:
Fixes #623. Fixes #629. Relates to #642.
What is the new behavior?
versions.jsonOther information
This should be the last PR before switching
masterto version9.xand enabling Ivy.This is deployed for verification to: https://material2-docs-dev.firebaseapp.com/components/checkbox/overview