This repository was archived by the owner on Dec 18, 2024. It is now read-only.
feat: update to 9.0.0-next.x and enable Ivy rendering engine #645
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allow the exported/downloaded project from StackBlitz to be functional - move files into /src and /src/app to match a normal configuration rename Stackblitz to StackBlitz use StackBlitz logo to launch examples use a relative URL for downloading `versions.json` update Ivy fix for VersionPicker log errors during app bootstrap in StackBlitz switch StackBlitz examples to SCSS fix lint warnings in deploy script add ignores for Firebase Fixes #623. Fixes #629. Relates to #642.
Decorates all declared undecorated provider classes with @Injectable
add 9.0.0-next.0 to versions list - point it to material2-docs-dev for now
the prior version used `yarn@1.10.1` - @angular-devkit/build-angular@0.900.0-next.8 throws an error - Expected version ">= 1.13.0". Got "1.10.1"
re-enable Angular CLI's build-optimizer
|
I wanted to keep these separate commits, but it looks like they all got squashed on merge. |
jelbourn
added a commit
to jelbourn/material.angular.io
that referenced
this pull request
Nov 3, 2021
PR angular#645 erroneously changed this to a relative url. We want this to always use the latest material.angular.io so that we don't have to update old branches for new major versions.
jelbourn
added a commit
that referenced
this pull request
Nov 3, 2021
PR #645 erroneously changed this to a relative url. We want this to always use the latest material.angular.io so that we don't have to update old branches for new major versions.
jelbourn
added a commit
that referenced
this pull request
Nov 3, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check that your PR fulfills the following requirements:
What is the current behavior?
The app is based on Angular, CLI, and Material version
8.xand Ivy is disabled.What is the new behavior?
The app is based on Angular, CLI, and Material version
9.0.0-next.xand Ivy is enabled.Stats
Stats from production builds deployed to Firebase Hosting (CDN).
The times in
mswere the best scores of approximately 10 page reloads with cache disabled in ChromeVersion 77.0.3865.90 (Official Build) (64-bit).Note that due to the way that the app is architected (how it pulls in example modules from the
angular/material2-docs-contentrepo), we don't currently do any lazy loading.See PR diff for different versions of libraries between the before/after.
Landing Page before Ivy
transferred: 819 KB
resources: 4.1 MB
Finish: 637 ms
DOMContentLoaded: 435 ms
Load: 565 ms
Landing Page after Ivy
transferred: 686 KB ✅ -130 KB
resources: 2.5 MB ✅ -1.6 MB
Finish: 571 ms ✅ approx. -66 ms
DOMContentLoaded: 392 ms ✅ approx. -43 ms
Load: 498 ms ✅ approx. -67 ms
Landing Page with Ivy and build-optimizer enabled
transferred: 607 KB ✅ -79 KB
resources: 2.3 MB ✅ -0.2 MB
Finish: 570 ms ✅ approx. -1 ms
DOMContentLoaded: 372 ms ✅ approx. -20 ms
Load: 498 ms ✅ approx. 0 ms
Checkbox Overview before Ivy
transferred: 846 KB
resources: 4.1 MB
Finish: 822 ms
DOMContentLoaded: 470 ms
Load: 741 ms
Checkbox Overview after Ivy
transferred: 713 KB ✅ -133 KB
resources: 2.5 MB ✅ -1.6 MB
Finish: 809 ms ✅ approx. -13 ms
DOMContentLoaded: 419 ms ✅ approx. -51 ms
Load: 736 ms ✅ approx. -5 ms
Checkbox Overview with Ivy and build-optimizer enabled
transferred: 634 KB ✅ -79 KB
resources: 2.3 MB ✅ -0.2 MB
Finish: 763 ms ✅ approx. -46 ms
DOMContentLoaded: 417 ms ✅ approx. -2 ms
Load: 698 ms ✅ approx. -38 ms
Other information
This PR re-enables Angular CLI's build-optimizer which was disabled in this commit without any kind of comment or explanation.
This PR is blocked on PR #643 getting merged first.