Skip to content

Reduced size of end-to-end test tslint.json rulesets #217

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 15 commits into from
Closed

Reduced size of end-to-end test tslint.json rulesets #217

wants to merge 15 commits into from

Conversation

JoshuaKGoldberg
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg commented Oct 6, 2019 •
edited
Loading

PR Checklist

Overview

Reduces the enabled rules in end-to-end tslint.jsons to 3. Renames the file containing expected file content from expected.json to expected.txt.

JoshuaKGoldberg
JoshuaKGoldberg commented Oct 6, 2019
View reviewed changes
Copy link
Member Author

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll need to add back a couple of features...

@JoshuaKGoldberg JoshuaKGoldberg self-assigned this Oct 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 6, 2019
Merged
@JoshuaKGoldberg
Copy link
Member Author

I'm finding these frustrating to deal with so I'm just going to delete end-to-end tests. 🤷‍♂

@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 6, 2019
Closed
@JoshuaKGoldberg JoshuaKGoldberg deleted the smaller-end-to-end-tslints branch October 6, 2019 22:55
@JoshuaKGoldberg JoshuaKGoldberg mentioned this pull request Oct 6, 2019
Merged
2 tasks
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for author The PR author should address requested changes label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@JoshuaKGoldberg JoshuaKGoldberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

End-to-end TSLint configurations have too many rules enabled
1 participant
@JoshuaKGoldberg