Reduced size of end-to-end test tslint.json rulesets

docs/Testing.md

@@ -32,8 +32,8 @@ End-to-end tests that execute the `bin/tslint-to-eslint` command and validate ou
 Each directory there contains:
 
 -   `test.ts`: Test file that runs `createTests(__dirname);` to set up tests in that directory
--   `.eslintrc.json`: `.gitignore`d output from the most recent test run
--   `expected.json`: Expected output ESLint configuration
+-   `.eslintrc.js`: `.gitignore`d output from the most recent test run
+-   `expected.txt`: Expected output ESLint configuration
 -   `stderr.txt`: Expected output written to the process `stderr`
 -   `stdout.txt`: Expected output written to the process `stdout`
 -   `tslint.json`: Original TSLint configuration file to convert

test/createTestArgs.ts

@@ -6,7 +6,7 @@ const readdir = promisify(fs.readdir);
 
 export const createTestArgs = async (cwd: string, extraArgs: string[]) => {
     const items = new Set(await readdir(cwd));
-    const flags = ["--config", path.join(cwd, ".eslintrc.json")];
+    const flags = ["--config", path.join(cwd, ".eslintrc.js")];
 
     if (items.has("tslint.json")) {
         flags.push("--tslint", path.join(cwd, "tslint.json"));

test/createTests.ts

@@ -27,7 +27,7 @@ const binFile = path.join(__dirname, "../bin/tslint-to-eslint-config");
 
 export const createTests = (
     cwd: string,
-    { eslint = "./.eslintrc.json", extraArgs = [] }: TestSettings = {},
+    { eslint = "./.eslintrc.js", extraArgs = [] }: TestSettings = {},
 ) => {
     const testName = path.basename(cwd);
     const accept = "acceptTestChanges" in globalThis;
@@ -52,7 +52,7 @@ export const createTests = (
             // Act
             await act(testArgs);
 
-            await assertFileContents(cwdPath("expected.json"), await readTestFile(eslint), accept);
+            await assertFileContents(cwdPath("expected.txt"), await readTestFile(eslint), accept);
         });
 
         test("stderr", async () => {

test/tests/custom eslint path/.eslintrc.custom.js

@@ -0,0 +1,22 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
+    },
+    "extends": [],
+    "rules": {
+        "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/no-floating-promises": "error",
+        "previously-existing-rule": "warn",
+    },
+    "globals": {},
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "plugins": [
+        "@typescript-eslint"
+    ]
+};

test/tests/custom eslint path/expected.txt

@@ -0,0 +1,22 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
+    },
+    "extends": [],
+    "rules": {
+        "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/no-floating-promises": "error",
+        "previously-existing-rule": "warn",
+    },
+    "globals": {},
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "plugins": [
+        "@typescript-eslint"
+    ]
+};

test/tests/custom eslint path/stdout.txt

@@ -1,5 +1,2 @@
-✨ 19 rules replaced with their ESLint equivalents. ✨
-️👀 2 rules do not yet have ESLint equivalents; defaulting to eslint-plugin-tslint. 👀
-⚡ 1 package is required for new ESLint rules. ⚡
-	unicorn
+✨ 2 rules replaced with their ESLint equivalents. ✨
 ✅ All is well! ✅

test/tests/custom eslint path/test.ts

@@ -1,8 +1,8 @@
 import { createTests } from "../../createTests";
 
-const eslint = "./eslintrc.js";
+const eslint = "./.eslintrc.custom.js";
 
 createTests(__dirname, {
     eslint,
-    extraArgs: ["--eslint", eslint],
+    extraArgs: ["--config", eslint, "--eslint", eslint],
 });

test/tests/custom eslint path/tslint-to-eslint-config.log

@@ -1,2 +0,0 @@
-no-implicit-dependencies does not yet have an ESLint equivalent.
-strict-boolean-expressions does not yet have an ESLint equivalent.

test/tests/custom eslint path/tslint.json

@@ -1,35 +1,7 @@
 {
     "rules": {
         "array-type": [true, "array"],
-        "arrow-return-shorthand": false,
-        "completed-docs": false,
-        "comment-format": false,
-        "file-name-casing": false,
-        "linebreak-style": false,
-        "interface-name": [true, "never-prefix"],
-        "member-ordering": false,
-        "newline-before-return": false,
-        "no-any": false,
-        "no-bitwise": false,
-        "no-empty": false,
-        "no-magic-numbers": false,
-        "no-import-side-effect": false,
-        "no-implicit-dependencies": [true, "dev"],
-        "no-null-keyword": false,
-        "no-parameter-reassignment": false,
-        "no-parameter-properties": false,
-        "no-submodule-imports": false,
-        "no-unbound-method": false,
-        "no-unused-variable": false,
-        "no-use-before-declare": false,
-        "prefer-conditional-expression": false,
-        "prefer-method-signature": false,
-        "prefer-switch": false,
-        "prefer-template": false,
-        "promise-function-async": false,
-        "strict-boolean-expressions": [true, "allow-boolean-or-undefined", "allow-number"],
-        "switch-default": false,
-        "switch-final-break": false,
+        "no-floating-promises": true,
         "typedef": false
     }
 }

test/tests/custom package path/.eslintrc.js

@@ -0,0 +1,21 @@
+module.exports = {
+    "env": {
+        "browser": true,
+        "es6": true,
+        "node": true
+    },
+    "extends": [],
+    "rules": {
+        "@typescript-eslint/array-type": "error",
+        "@typescript-eslint/no-floating-promises": "error"
+    },
+    "globals": {},
+    "parser": "@typescript-eslint/parser",
+    "parserOptions": {
+        "project": "tsconfig.json",
+        "sourceType": "module"
+    },
+    "plugins": [
+        "@typescript-eslint"
+    ]
+};