-
Notifications
You must be signed in to change notification settings - Fork 101
Addresses: #144 Script creates wrongly named file on Windows #209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally great, just curious about the dependency addition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -27,7 +27,7 @@ export const runCli = async ( | |||
.option("-V --version", "output the package version"); | |||
|
|||
const parsedArgv = { | |||
config: "./eslintrc.js", | |||
config: "./.eslintrc.js", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You'll also want to change the createTests.ts
default path, and rename the files in test/tests/*
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll do this in #217.
PR Checklist
status: accepting prs
Overview
Updates runCli to set the default value for output file to
.eslintrc.js
with a.
instead ofeslintrc.js
without a.
.Introduces a unit test to confirm this behavior.