Skip to content

Addresses: #144 Script creates wrongly named file on Windows #209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 6, 2019

Conversation

KleeUT
Copy link
Contributor

@KleeUT KleeUT commented Oct 5, 2019

PR Checklist

Overview

Updates runCli to set the default value for output file to .eslintrc.js with a . instead of eslintrc.js without a ..
Introduces a unit test to confirm this behavior.

@KleeUT KleeUT changed the title #144 Addresses: #144 Script creates wrongly named file on Windows Oct 5, 2019
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally great, just curious about the dependency addition?

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing this separately for #217 found a few necessary changes. I'll run those separately. Thanks for tackling the file name change @KleeUT!

@@ -27,7 +27,7 @@ export const runCli = async (
.option("-V --version", "output the package version");

const parsedArgv = {
config: "./eslintrc.js",
config: "./.eslintrc.js",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll also want to change the createTests.ts default path, and rename the files in test/tests/*.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do this in #217.

@JoshuaKGoldberg JoshuaKGoldberg merged commit c2e5d0d into typescript-eslint:master Oct 6, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script creates wrongly named file on Windows
2 participants