Skip to content

add converter for space-within-parens rule #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Oct 7, 2019
Merged

add converter for space-within-parens rule #193

merged 7 commits into from
Oct 7, 2019

Conversation

bmeverett
Copy link
Contributor

PR Checklist

Overview

@bmeverett bmeverett force-pushed the space-within-parens branch from 104fc0e to c29646e Compare October 2, 2019 23:15
JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 4, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The overall setup is fine, but the rule arguments need to be converted still.

@JoshuaKGoldberg JoshuaKGoldberg added the status: waiting for author The PR author should address requested changes label Oct 4, 2019
@bmeverett bmeverett force-pushed the space-within-parens branch from 8ff962c to f198132 Compare October 4, 2019 12:38
JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 4, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost!

JoshuaKGoldberg
JoshuaKGoldberg requested changes Oct 6, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting closer!

@bmeverett bmeverett force-pushed the space-within-parens branch from 51b19c7 to da9ff73 Compare October 6, 2019 21:49
@JoshuaKGoldberg JoshuaKGoldberg added status: waiting for reviewer Waiting for a maintainer to review and removed status: waiting for author The PR author should address requested changes labels Oct 7, 2019
JoshuaKGoldberg
JoshuaKGoldberg approved these changes Oct 7, 2019
View reviewed changes
Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb. Thanks @bmeverett! 🙌

@JoshuaKGoldberg JoshuaKGoldberg merged commit d8d34d8 into typescript-eslint:master Oct 7, 2019
@JoshuaKGoldberg JoshuaKGoldberg removed the status: waiting for reviewer Waiting for a maintainer to review label Oct 10, 2019
@cheeZery cheeZery mentioned this pull request Dec 30, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoshuaKGoldberg JoshuaKGoldberg JoshuaKGoldberg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing converter: space-within-parens
2 participants
@bmeverett @JoshuaKGoldberg