add notices for space-within-parens

Author: bmeverett

src/rules/converters.ts

@@ -229,7 +229,7 @@ export const converters = new Map([
     // if you're willing to take on that work, that'd be great! Please send PRs! 💖
     // as these are enabled, they should be added in sorted order to the list above.
 
-    // tSLint core rules:
+    // TSLint core rules:
     // ["ban", convertBan], // no-restricted-properties
     // ["import-blacklist", convertImportBlacklist], // no-restricted-imports
     // ["newline-before-return", convertNewlineBeforeReturn],

src/rules/converters/space-within-parens.ts

@@ -1,17 +1,13 @@
 import { RuleConverter } from "../converter";
 
 export const convertSpaceWithinParens: RuleConverter = tslintRule => {
-    let arg = "";
-    if (tslintRule.ruleArguments.length === 1) {
-        arg = "always";
-    } else {
-        arg = "never";
-    }
+    const arg = tslintRule.ruleArguments.length === 1 ? "always" : "never";
     return {
         rules: [
             {
                 ruleArguments: [arg],
                 ruleName: "@typescript-eslint/space-within-parens",
+                notices: ["The number of spaces will be ignored"],
             },
         ],
     };

src/rules/converters/tests/space-within-parens.test.ts

@@ -11,6 +11,7 @@ describe(convertSpaceWithinParens, () => {
                 {
                     ruleArguments: ["never"],
                     ruleName: "@typescript-eslint/space-within-parens",
+                    notices: ["The number of spaces will be ignored"],
                 },
             ],
         });
@@ -26,6 +27,7 @@ describe(convertSpaceWithinParens, () => {
                 {
                     ruleArguments: ["always"],
                     ruleName: "@typescript-eslint/space-within-parens",
+                    notices: ["The number of spaces will be ignored"],
                 },
             ],
         });