add notice only if parameter supplied

Author: bmeverett

src/rules/converters.ts

@@ -272,10 +272,10 @@ export const converters = new Map([
     ["quotemark", convertQuotemark],
     ["triple-equals", convertTripleEquals],
 
-    // these converters are all for rules that need more complex option conversions.
-    // some of them will likely need to have notices about changed lint behaviors...
-    // if you're willing to take on that work, that'd be great! Please send PRs! 💖
-    // as these are enabled, they should be added in sorted order to the list above.
+    // These converters are all for rules that need more complex option conversions.
+    // Some of them will likely need to have notices about changed lint behaviors...
+    // If you're willing to take on that work, that'd be great! Please send PRs! 💖
+    // As these are enabled, they should be added in sorted order to the list above.
 
     // TSLint core rules:
     // ["ban", convertBan], // no-restricted-properties

src/rules/converters/space-within-parens.ts

@@ -1,13 +1,20 @@
 import { RuleConverter } from "../converter";
 
 export const convertSpaceWithinParens: RuleConverter = tslintRule => {
-    const arg = tslintRule.ruleArguments.length === 1 ? "always" : "never";
+    let arg = "never";
+    const notices = [];
+
+    if (tslintRule.ruleArguments.length === 1) {
+        arg = "always";
+        notices.push("The number of spaces will be ignored");
+    }
+
     return {
         rules: [
             {
                 ruleArguments: [arg],
                 ruleName: "@typescript-eslint/space-within-parens",
-                notices: ["The number of spaces will be ignored"],
+                notices,
             },
         ],
     };

src/rules/converters/tests/space-within-parens.test.ts

@@ -11,7 +11,7 @@ describe(convertSpaceWithinParens, () => {
                 {
                     ruleArguments: ["never"],
                     ruleName: "@typescript-eslint/space-within-parens",
-                    notices: ["The number of spaces will be ignored"],
+                    notices: [],
                 },
             ],
         });