Skip to content

issue #143 #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Merged

Conversation

nqviet
Copy link
Contributor

@nqviet nqviet commented Nov 16, 2021

Fixed: updated query state when challenges-app is remounted

Note:

Case 1 (fixed): https://take.ms/siOo2
Case 2 (external error): https://take.ms/Ef0hH

For case-2, can it be fixed in gigs-app? When user fast clicks on menu, the two apps are initialized in parallel.

attachments: 2021-11.zip

@LieutenantRoger
Copy link
Collaborator

Hello @nqviet

  1. It looks the PR is conflicting, could you please resolve the conflicts ?

  2. For the case 2, thanks for report it. Yes, please send a PR into the gigs repo to fix it : https://github.com/topcoder-platform/micro-frontends-gigs-app/tree/challenges-bug-bash (I have bumped the price into $40 to compensate this case)

Thank you.

@nqviet
Copy link
Contributor Author

nqviet commented Nov 17, 2021

Hi @LieutenantRoger

--> (case 1): conflict resolved
--> (case 2): PR for gigs-app is ready: topcoder-platform/micro-frontends-gigs-app#73

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants