Changes manifest file extension from json to js. #8494
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The json -file is only meant for Symfony asset versioning when the js -file creates `window.webpackJsonp` used in bundles.
|
This was only recently changed in #8438. Can someone confirm which extension is the right one? ping @weaverryan |
|
I've just rebuild all assets for symfony.com app:
There are two manifest files:
In symfony.com templates we have this: <script src="{{ asset('build/manifest.js') }}"></script>The JSON file is only used in the framework:
assets:
json_manifest_path: '%kernel.project_dir%/web/build/manifest.json' |
javiereguiluz
approved these changes
Oct 10, 2017
There was a problem hiding this comment.
👍 I'm sorry for the confusion and for having approved #8438, which introduced this bug.
weaverryan
approved these changes
Oct 11, 2017
|
Thank you @Cifixie. |
xabbuh
added a commit
that referenced
this pull request
Oct 13, 2017
This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #8494). Discussion ---------- Changes manifest file extension from json to js. JSON as itself isn't valid Javascript causing an error when trying to parse as javascript: `manifest.json:2 Uncaught SyntaxError: Unexpected token :` and it's only meant for Symfony asset versioning. The bundler also creates `manifest.js` -file which creates `window.webpackJsonp` used in bundles. Without it, you might get an error: `app.315f91d41365513eb8ea.js:1 Uncaught ReferenceError: webpackJsonp is not defined` Commits ------- 5d13c37 Changes manifest file extension from json to js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON as itself isn't valid Javascript causing an error when trying to parse as javascript:
manifest.json:2 Uncaught SyntaxError: Unexpected token :and it's only meant for Symfony asset versioning.The bundler also creates
manifest.js-file which createswindow.webpackJsonpused in bundles. Without it, you might get an error:app.315f91d41365513eb8ea.js:1 Uncaught ReferenceError: webpackJsonp is not defined