Skip to content

Changes manifest file extension from json to js. #8494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions frontend/encore/shared-entry.rst
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ on your page before any other JavaScript file:
.. code-block:: twig

<!-- these two files now must be included in every page -->
<script src="{{ asset('build/manifest.json') }}"></script>
<script src="{{ asset('build/manifest.js') }}"></script>
<script src="{{ asset('build/vendor.js') }}"></script>

<!-- here you link to the specific JS files needed by the current page -->
Expand All @@ -42,7 +42,7 @@ on your page before any other JavaScript file:
<link rel="stylesheet" href="{{ asset('build/vendor.css') }}" />

The ``vendor.js`` file contains all the common code that has been extracted from
the other files, so it's obvious that it must be included. The other file (``manifest.json``)
the other files, so it's obvious that it must be included. The other file (``manifest.js``)
is less obvious: it's needed so that Webpack knows how to load those shared modules.

.. tip::
Expand Down