Skip to content

fix typo in filename #8438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2017
Merged

fix typo in filename #8438

merged 1 commit into from
Oct 4, 2017

Conversation

ousmaneNdiaye
Copy link
Contributor

Filename should be "manifest.json" instead of "manifest.js"

Filename should be "manifest.json" instead of "manifest.js"
Copy link
Member

@javiereguiluz javiereguiluz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch!

@xabbuh xabbuh added this to the 3.3 milestone Oct 3, 2017
@wouterj
Copy link
Member

wouterj commented Oct 4, 2017

Great! Thanks for fixing it Ousmane!

@wouterj wouterj merged commit c7a86fc into symfony:3.3 Oct 4, 2017
wouterj added a commit that referenced this pull request Oct 4, 2017
This PR was merged into the 3.3 branch.

Discussion
----------

fix typo in filename

Filename should be "manifest.json" instead of "manifest.js"

Commits
-------

c7a86fc fix typo in filename
@ousmaneNdiaye ousmaneNdiaye deleted the patch-1 branch October 4, 2017 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants