Skip to content

[WIP] Change wording of voters #3326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 26, 2013
Merged

Conversation

FlorianLB
Copy link

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #2806

A paragraph about what "something" can be is necessary ?

* ``VoterInterface::ACCESS_ABSTAIN``: The voter cannot decide if the user is granted or not
* ``VoterInterface::ACCESS_DENIED``: The user is not allowed to access the application
* ``VoterInterface::ACCESS_DENIED``: The user is not allowed to access something
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure with these play of words and clarifications later

would resource be better?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the base phrasing would be something like Asked authorization will be refused by this voter. Stressing that we're dealing with a specific question, and that other Voters may decide, is important.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think resource is better than something.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 for @romaricdrigon proposal

weaverryan added a commit that referenced this pull request Dec 26, 2013
@weaverryan weaverryan merged commit 9bbac06 into symfony:2.3 Dec 26, 2013
weaverryan added a commit that referenced this pull request Dec 26, 2013
@weaverryan
Copy link
Member

Hi guys!

I've used @romaricdrigon's suggestion at sha: 2f89b3a with some other changes.

This article is quite old, and I think now it doesn't really explain things very well (for example, it never shows you how to use the voter - which I think causes some of the confusion). But, that's no worry - when I merge in #3138, I'll look at both articles. Right now, I think there would be a lot repeated between the 2, so we'll need to fix that :).

Thanks Florian and everyone else!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants