[WIP] create voters_data_permission.rst article #3138
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you prefix your PR title with |
|
done |
| .. index:: | ||
| single: Security; Data Permission Voters | ||
|
|
||
| How to implement your own Voter to check the permission for a object agains a user |
There was a problem hiding this comment.
to check user permissions for accessing a given object
|
|
||
| .. code-block:: php | ||
|
|
||
| $container |
There was a problem hiding this comment.
add // src/Acme/DemoBundle/Resources/config/services.php above this line
|
Sorry @monbro for so many comments. I really like the work you have done so far! All these comments are only small issues which should be fixed easily. |
|
@xabbuh no worries, you are making good points! These conflicts should be solved now. You can have another look. |
| user is granted access. This method must return one of the following values: | ||
|
|
||
| * ``VoterInterface::ACCESS_GRANTED``: The user is allowed to access the | ||
| application |
There was a problem hiding this comment.
these items should start at the same level as the backticks of the previous line. So:
* ``VoterInterface::ACCESS_GRANTED``: The user is allowed to access the
applicationThere was a problem hiding this comment.
btw, same for the other list items below
|
So ready for another review! |
weaverryan
added a commit
that referenced
this pull request
Feb 20, 2014
weaverryan
added a commit
that referenced
this pull request
Mar 4, 2014
This PR was merged into the 2.3 branch. Discussion ---------- New Data Voter Article (continuation) Hiya guys! This is just a continuation of #3138 by @monbro. I needed to rebase it against the 2.3 branch (which had conflicts), and wanted to proofread it (hence the fresh PR). Please check out my latest commit to see if I've made any mistakes :). | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3 | Fixed tickets | #2877 Thanks! Commits ------- d3f9383 [#3594] Nice tweaks thanks to @wouterj and @xabbuh 2391758 [#2877][#3138] Proofreading the new voter data permission entry 11aead7 simplified the example 8227270 updated according to the review da7b97e missed one comment 9b91501 updated the docs according to the last review 872a05f updated the link from ACL to the data permission voters 1fd3b0e updated docs according to the review 5275230 updated with missing fixes f4eb5f3 updated docs according to the reviews ee0def1 improved tip box with additional link to /cookbook/security 731dcad updated page with suggestion from the review 1466fa7 improvements according to the reviews 99b1b0f a couple of changes according to the comments, not finished now 2bda150 create voters_data_permission.rst article
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a draft about how the article for a data permission voter could look like. I am happy about feedback. I will try to improve this article the next days.
This pull-request will solve this issue #2877