[HttpClient] better explain how to deal with exceptions #13136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 14, 2020
nicolas-grekas
force-pushed
the
hc-error
branch
from
738cfec to
ea38d7f
Compare
nicolas-grekas
force-pushed
the
hc-error
branch
from
ea38d7f to
61cddf5
Compare
|
Perfectly describes what really happens, definitely missing part of docs - 👍 |
B-Galati
reviewed
Feb 14, 2020
| } elseif ($chunk->isFirst()) { | ||
| // if you want to check the status code, you must do it when the | ||
| // first chunk arrived, using $response->getStatusCode(); | ||
| // not doing so might trigger an HttpExceptionInterface |
There was a problem hiding this comment.
Because the response headers might not be arrived yet? I am not sure to understand in which case it can happen.
There was a problem hiding this comment.
It happens because that's how the first chunk behaves : if status code is unchecked after it, an exception is thrown. I'm going to improve this
There was a problem hiding this comment.
It was a little bit confusing that the exception is thrown from the iterator(generator), so you can not catch it inside a for-each cycle and continue to process other requests.
|
Thanks Nicolas! |
|
Yup, much better explained than I tried to. Thank you :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #13078 and #13134