Skip to content

[HttpClient] Try to make the exception handling more clear #13134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[HttpClient] Try to make the exception handling more clear #13134

wants to merge 1 commit into from

Conversation

clemherreman
Copy link
Contributor

Not sure that this clarification is worth it, as it is more like the consequence of #13078

@clemherreman clemherreman changed the title Try to make the exception handling more clear [HttpClient] Try to make the exception handling more clear Feb 14, 2020
@nicolas-grekas nicolas-grekas mentioned this pull request Feb 14, 2020
Merged
@nicolas-grekas
Copy link
Member

Thanks, replaced by #13136

javiereguiluz added a commit that referenced this pull request Feb 15, 2020
@javiereguiluz
minor #13136 [HttpClient] better explain how to deal with exceptions …
5f791ca 
…(nicolas-grekas)

This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] better explain how to deal with exceptions

Replaces #13078 and #13134

Commits
-------

61cddf5 [HttpClient] better explain how to deal with exceptions
@clemherreman clemherreman deleted the patch-2 branch February 17, 2020 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas Awaiting requested review from nicolas-grekas

Assignees
No one assigned
Labels
Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@clemherreman @nicolas-grekas @carsonbot