Skip to content

[HttpClient] Added notes about handling errors when multiplexing responses #12896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

a-menshchikov
Copy link
Contributor

Related to #35144.

Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@HeahDude HeahDude added this to the 4.3 milestone Jan 17, 2020
…xx status codes and about handling timeout in the same case
@a-menshchikov a-menshchikov force-pushed the http-client-first-chunk branch from a1edcfd to ed7aabd Compare January 17, 2020 18:46
@HeahDude HeahDude modified the milestones: 4.3, 4.4 Feb 9, 2020
Copy link
Contributor

@HeahDude HeahDude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @a-menshchikov, can you please rebase onto 4.4?

@nicolas-grekas
Copy link
Member

Actually I think this PR should be closed now, after my last PR.

@HeahDude
Copy link
Contributor

Ok, thank you @nicolas-grekas for the heads up.

Thank you @a-menshchikov for this first contribution, sorry I have to close it now that #13136 is merged. Looking forward to your next PR :). Cheers!

@HeahDude HeahDude closed this Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants