DATAMONGO-1590 - Add test checking Persistable.isNew() is considered. #436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…egation $group stage. Original Pull Request: #360 CLA: 171720160409030719 (Gustavo de Geus)
Just added overloads for stdDevSamp and stdDevPop taking AggregationExpression and updated the doc. Also replaced String operation based MongoDB operation building by using operators directly. Original Pull Request: #360
We new support $filter in aggregation pipeline.
Aggregation.newAggregation(Sales.class,
Aggregation.project()
.and(filter("items").as("item").by(GTE.of(field("item.price"), 100)))
.as("items"))
Original pull request: #412.
Remove variable before returning value. Add generics for list creation. Original pull request: #412.
…roup & project. We now directly support comparison aggregation operators ($cmp, $eq, $gt, $gte, $lt, $lte and $ne) on both group and project stages. Original pull request: #414.
Add JavaDoc for compareValue. Original pull request: #414.
…line operators. Original Pull Request: #410
Add missing transformations for ConstructorReference, OperatorNot, OpNE, OpEQ, OpGT, OpGE, OpLT, OpLE, OperatorPower, OpOr and OpAnd. This allows usage of logical operators &, || and ! as part of the expression, while ConstructorReference allows instantiating eg. arrays via an expression `new int[]{4,5,6}`. This can be useful eg. comparing arrays using $setEquals.
More complex aggregation operators like $filter can be created by defining the variable references as string inside the expression like filter(a, 'num', '$$num' > 10).
Commands like $let requires usage of InlineMap to pass in required arguments like eg. let({low:1, high:'$$low'}, gt('$$low', '$$high')).
Original Pull Request: #410
We now correctly convert entities into their MongoDB representation including type information via _class property. Original pull request: #415.
We now use more type information to create a better empty collection in the first place. The previous algorithm always used an empty HashSet plus a subsequent conversion using the raw collection type. Especially the latter caused problems for EnumSets as the conversion into one requires the presence of component type information. We now use Spring's collection factory and more available type information to create a proper collection in the first place and only rely on a subsequent conversion for arrays.
Introducing dedicated annotations for manually defined count and delete queries to avoid misconfiguration and generally simplifying the declaration. Original pull request: 416.
Renamed @count and @delete to @CountQuery and @deleteQuery. Minor polishing in test cases and test repository methods. JavaDoc, formatting. Original pull request: #416.
…e and set operations. We now support the following aggregation framework operators: - setEquals, setIntersection, setUnion, setDifference, setIsSubset, anyElementTrue, allElementsTrue - stdDevPop, stdDevSamp - abs, ceil, exp, floor, ln, log, log10, pow, sqrt, trunc - arrayElementAt, concatArrays, isArray - literal - dayOfYear, dayOfMonth, dayOfWeek, year, month, week, hour, minute, second, millisecond, dateToString Original pull request: #418.
Add JavaDoc. Change visibility of AbstractAggregationExpression.getMongoMethod() to protected. Original pull request: #418.
…y methods.
We now support exists projections for query methods in query methods for derived and string queries.
public PersonRepository extends Repository<Person, String> {
boolean existsByFirstname(String firstname);
@ExistsQuery(value = "{ 'lastname' : ?0 }")
boolean someExistQuery(String lastname);
@query(value = "{ 'lastname' : ?0 }", exists = true)
boolean anotherExistQuery(String lastname);
}
Original pull request: #381.
Formatting in test case. Original pull request: #381.
Sorting update modifier added. Supports sorting arrays by document fields and element values. Original pull request: #405.
Add property to field name mapping for Sort orders by moving Sort mapping to UpdateMapper. Fix typo. Add JavaDoc. Reformat code. Remove trailing whitespaces. Original pull request: #405.
Aligned assertion messages for consistency. Fixed imports in UpdateMapperUnitTests. Original pull request: #405.
This is required for the switch in support for multi-store detection. Related ticket: DATACMNS-952.
We now support $map operator in aggregation. Original pull request: #420.
Reduce Map aggregation expression builder entrypoint. Fix JavaDoc. Original pull request: #420.
…iaDefinition. We now also accept CriteriaDefinition next to Criteria for Aggregation.match. The existing match(Criteria) method remains to preserve binary compatibility.
… of AggregationExpressions. Renamed CondOperator to Cond and IfNullOperator to IfNull. Both conditional operations are now available from ConditionalOperators.when and ConditionalOperators.ifNull and accept AggregationExpressions for conditions and values. Original Pull Request: #421
Added some static entry points for better readability. Original Pull Request: #421
We now support $let in aggregation $project stage.
ExpressionVariable total = newExpressionVariable("total").forExpression(ADD.of(field("price"), field("tax")));
ExpressionVariable discounted = newExpressionVariable("discounted").forExpression(Cond.when("applyDiscount").then(0.9D).otherwise(1.0D));
newAggregation(Sales.class,
project()
.and(define(total, discounted)
.andApply(MULTIPLY.of(field("total"), field("discounted"))))
.as("finalTotal"));
Original pull request: #417.
Use InheritingExposedFieldsAggregationOperationContext instead of anonymous context class for condition mapping. Drop aggregation input collections before tests. Minor reformatting. Original pull request: #417.
We now support the following MongoDB 3.4 aggregation operators: $indexOfBytes, $indexOfCP, $split, $strLenBytes, $strLenCP, $substrCP, $indexOfArray, $range, $reverseArray, $reduce, $zip, $in, $isoDayOfWeek, $isoWeek, $isoWeekYear, $switch and $type. Original pull request: #423.
Replace Spring Data Document with Spring Data MongoDB. Extend copyright year range. Replace static Spring version leftover with variable. Fix typos.
…nitTests. Original pull request: #398.
Add ticket references to test methods. Extend license years in copyright header. Original pull request: #398.
Add note on lifecycle event handling for property types.
Field projections now expose their fields as synthetic simple fields. Projection aggregation stage redefines the available field set available for later aggregation stages entirely so projected fields are considered synthetic. A simple synthetic field has no target field which causes later aggregation stages to not pick up the underlying target but the exposed field name when rendering aggregation operations to Mongo documents. The change is motivated by a bug where previously an aggregation consisting of projection of an aliased field and sort caused the sort projection stage to render with the original field name instead of the aliased field. The sort did not apply any sorting since projection redefines the available field set entirely and the original field is no longer accessible. Original Pull Request: #433
Update documentation for better readability in html and pdf format. Original Pull Request: #433
…Context.getReferenceFor(…). We now consider the provided field name (alias) in mapped fields with which it is exposed. The field name applies to the exposed field after property path resolution in TypeBasedAggregationOperationContext. Previously, the field reference used the property name which caused fields to be considered non-aliased, so aggregation projection operations dropped the alias and exposed the field with its leaf property name. Original Pull Request: #434
…er type. We now allow using sub types as arguments for derived queries. This makes it possible to use eg. a GeoJsonPoint for querying while the declared property type in the domain object remains a regular (legacy) Point. Original pull request: #435.
Remove unused fields. Fix typo in method name. Reformat inner class to align formatting. Original pull request: #435.
…New(). Prepare issue branch. Related to: DATCMNS-976
…correctly. Related to: DATCMNS-976
odrotbohm
requested changes
Jan 17, 2017
christophstrobl
force-pushed
the
issue/DATAMONGO-1590
branch
from
fd12b92 to
979aa01
Compare
PersistableMongoEntityInformation considers and delegates calls to Persistable implementing types. Related to: DATCMNS-976
odrotbohm
pushed a commit
that referenced
this pull request
Jan 18, 2017
…ersistable. We now wrap the MappingMongoEntityInformation into one that delegates the methods implemented by Persistable to the actual entity in case it implements said interface. Original pull request: #436.
odrotbohm
added a commit
that referenced
this pull request
Jan 18, 2017
Removed some compiler warnings. Hide newly introduced class in package scope and made use of Lombok annotations to avoid boilerplate code. Original pull request: #436.
odrotbohm
pushed a commit
that referenced
this pull request
Jan 18, 2017
…ersistable. We now wrap the MappingMongoEntityInformation into one that delegates the methods implemented by Persistable to the actual entity in case it implements said interface. Original pull request: #436.
odrotbohm
added a commit
that referenced
this pull request
Jan 18, 2017
Removed some compiler warnings. Hide newly introduced class in package scope and made use of Lombok annotations to avoid boilerplate code. Original pull request: #436.
odrotbohm
pushed a commit
that referenced
this pull request
Jan 18, 2017
…ersistable. We now wrap the MappingMongoEntityInformation into one that delegates the methods implemented by Persistable to the actual entity in case it implements said interface. Original pull request: #436.
odrotbohm
added a commit
that referenced
this pull request
Jan 18, 2017
Removed some compiler warnings. Hide newly introduced class in package scope and made use of Lombok annotations to avoid boilerplate code. Original pull request: #436.
odrotbohm
pushed a commit
that referenced
this pull request
Jan 18, 2017
…ersistable. We now wrap the MappingMongoEntityInformation into one that delegates the methods implemented by Persistable to the actual entity in case it implements said interface. Original pull request: #436.
odrotbohm
added a commit
that referenced
this pull request
Jan 18, 2017
Removed some compiler warnings. Hide newly introduced class in package scope and made use of Lombok annotations to avoid boilerplate code. Original pull request: #436.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: DATCMNS-976
Related PR: spring-projects/spring-data-commons#191