DATAMONGO-1454 - Add support for exists projection in repository query methods. #381
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
odrotbohm
requested changes
Sep 26, 2016
| * @since 1.10 | ||
| * @return | ||
| */ | ||
| boolean exists() default false; |
There was a problem hiding this comment.
I wonder if we could derive that from the return type of the query method instead. Queries on MongoDB always return a document which can't be mapped to a boolean naturally. So we could just enable the exists execution for all query methods that return a boolean, can't we?
There was a problem hiding this comment.
That works for string-based queries quite well. I added a commit to derive count queries from a long return type.
mp911de
force-pushed
the
issue/DATAMONGO-1454
branch
4 times, most recently
from
c01a004 to
6743f4b
Compare
…y methods. Prepare issue branch.
mp911de
force-pushed
the
issue/DATAMONGO-1454
branch
from
6743f4b to
6fa3a86
Compare
…y methods.
We now support exists projections for query methods in query methods for derived and string queries.
public PersonReposotiry extends Repository<Person, String> {
boolean existsByFirstname(String firstname);
@ExistsQuery(value = "{ 'lastname' : ?0 }")
boolean someExistQuery(String lastname);
@query(value = "{ 'lastname' : ?0 }", exists = true)
boolean anotherExistQuery(String lastname);
}
mp911de
force-pushed
the
issue/DATAMONGO-1454
branch
from
6fa3a86 to
9d9fbfd
Compare
odrotbohm
pushed a commit
that referenced
this pull request
Dec 2, 2016
…y methods.
We now support exists projections for query methods in query methods for derived and string queries.
public PersonRepository extends Repository<Person, String> {
boolean existsByFirstname(String firstname);
@ExistsQuery(value = "{ 'lastname' : ?0 }")
boolean someExistQuery(String lastname);
@query(value = "{ 'lastname' : ?0 }", exists = true)
boolean anotherExistQuery(String lastname);
}
Original pull request: #381.
odrotbohm
added a commit
that referenced
this pull request
Dec 2, 2016
Formatting in test case. Original pull request: #381.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 2, 2016
…y methods.
We now support exists projections for query methods in query methods for derived and string queries.
public PersonRepository extends Repository<Person, String> {
boolean existsByFirstname(String firstname);
@ExistsQuery(value = "{ 'lastname' : ?0 }")
boolean someExistQuery(String lastname);
@query(value = "{ 'lastname' : ?0 }", exists = true)
boolean anotherExistQuery(String lastname);
}
Original pull request: #381.
odrotbohm
added a commit
that referenced
this pull request
Dec 2, 2016
Formatting in test case. Original pull request: #381.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support exists projections for query methods in query methods for derived and string queries.
Related ticket: DATAMONGO-1454
Depends on: spring-projects/spring-data-commons#171