DATAMONGO-1141 - Add support for $push $sort in Update. #405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prepare issue branch.
|
Or I can refactor it into a single modifier with one constructor accepting Sort and another accepting Direction, if you find it more appropriate. |
|
Hi @pavelvodrazka, thanks for this PR. The code looks pretty decent. Have you signed the CLA? Having one |
|
Hi Mark, thanks for review. Yes, I have signed the CLA. I'm going to refactor my changes and submit new PR in few minutes. |
pavelvodrazka
force-pushed
the
issue/DATAMONGO-1141
branch
2 times, most recently
from
a531d6e to
6bb0249
Compare
|
@mp911de I have pushed refactored modifier. Please revise. |
Sorting update modifier added. Supports sorting arrays by document fields and element values.
pavelvodrazka
force-pushed
the
issue/DATAMONGO-1141
branch
from
6bb0249 to
26bd879
Compare
|
Thanks a lot. I'll take the PR from here. |
odrotbohm
pushed a commit
that referenced
this pull request
Dec 2, 2016
Sorting update modifier added. Supports sorting arrays by document fields and element values. Original pull request: #405.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 2, 2016
Add property to field name mapping for Sort orders by moving Sort mapping to UpdateMapper. Fix typo. Add JavaDoc. Reformat code. Remove trailing whitespaces. Original pull request: #405.
odrotbohm
added a commit
that referenced
this pull request
Dec 2, 2016
Aligned assertion messages for consistency. Fixed imports in UpdateMapperUnitTests. Original pull request: #405.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 2, 2016
Sorting update modifier added. Supports sorting arrays by document fields and element values. Original pull request: #405.
odrotbohm
pushed a commit
that referenced
this pull request
Dec 2, 2016
Add property to field name mapping for Sort orders by moving Sort mapping to UpdateMapper. Fix typo. Add JavaDoc. Reformat code. Remove trailing whitespaces. Original pull request: #405.
odrotbohm
added a commit
that referenced
this pull request
Dec 2, 2016
Aligned assertion messages for consistency. Fixed imports in UpdateMapperUnitTests. Original pull request: #405.
|
That's polished, merged and forward-ported. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorting update modifiers added. DocumentSort for sorting arrays by document fields and ValueSort for sorting arrays by element values.