Skip to content

Fix #6506: Hide internal Tuple.fromArray implementation #6510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 16, 2019

Conversation

nicolasstucki
Copy link
Contributor

Renamed old fromArray to knowTupleFromArray and added a fromArray that a user can call.

Renamed old `fromArray` to `knowTupleFromArray` and added a `fromArray` that a user can call.
@milessabin
Copy link
Contributor

A "fromProduct" would also be useful :-)

@milessabin
Copy link
Contributor

Also from/to nested pairs ... but maybe I should just do these myself ;-)

@nicolasstucki nicolasstucki force-pushed the fix-#6506 branch 2 times, most recently from fd5485a to ed567c1 Compare May 14, 2019 15:13
@nicolasstucki nicolasstucki marked this pull request as ready for review May 14, 2019 15:45
@nicolasstucki
Copy link
Contributor Author

I added the fromProduct in #6514

Copy link
Contributor

@odersky odersky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise OK

@nicolasstucki nicolasstucki merged commit 2dd6345 into scala:master May 16, 2019
@nicolasstucki nicolasstucki deleted the fix-#6506 branch May 16, 2019 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants