Add Tuple.fromProduct #6514
Merged
Add Tuple.fromProduct #6514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolasstucki
force-pushed
the
add-tuple-fromProduct
branch
from
b802640 to
d7aa95e
Compare
liufengyun
approved these changes
May 16, 2019
tests/run/Tuple-fromProduct.scala
Outdated
| @@ -0,0 +1,47 @@ | |||
| import scala.reflect.ClassTag | |||
There was a problem hiding this comment.
Minor: this is not required, I guess
| // FIXME ProductN for N > 22 does not extends product | ||
| // testProduct((1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23)) | ||
| // testProduct((1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24)) | ||
| // testProduct((1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22, 23, 24, 25)) |
There was a problem hiding this comment.
This seems to be an oversight, I made the following changes, it seems to work:
-sealed class *:[+H, +T <: Tuple] extends NonEmptyTuple
+sealed abstract class *:[+H, +T <: Tuple] extends NonEmptyTuple with Product/cc: @odersky
There was a problem hiding this comment.
I'm looking into it as well. But this might not be what we want. The methods on product should also be specialized. For example productArity should do exactly the same as size.
Then there is the same issue for Tuple in general, not only non empty tuples. There the additional complete cation is that Unit is not a product.
There was a problem hiding this comment.
I think Unit probably should be a Product :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #6510