Skip to content

Add regression tests for Tuple and code some cleanup #6512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 16, 2019

Conversation

nicolasstucki
Copy link
Contributor

@nicolasstucki nicolasstucki commented May 14, 2019

Based on #6510

@nicolasstucki nicolasstucki force-pushed the add-tuple-toArray-test branch 3 times, most recently from 47fe061 to 7b0b819 Compare May 14, 2019 15:35
@nicolasstucki nicolasstucki changed the title Add regression tests for Tuple.toArray Add regression tests for Tuple May 14, 2019
@nicolasstucki nicolasstucki changed the title Add regression tests for Tuple Add regression tests for Tuple and code some cleanup May 14, 2019
@nicolasstucki nicolasstucki requested a review from liufengyun May 15, 2019 08:12
@nicolasstucki nicolasstucki force-pushed the add-tuple-toArray-test branch from 1c4a6ca to 1209bd0 Compare May 16, 2019 05:34
@nicolasstucki nicolasstucki marked this pull request as ready for review May 16, 2019 05:34
Copy link
Contributor

@liufengyun liufengyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liufengyun liufengyun merged commit 3a846cd into scala:master May 16, 2019
@liufengyun liufengyun deleted the add-tuple-toArray-test branch May 16, 2019 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants