This repository was archived by the owner on Sep 8, 2022. It is now read-only.
Parse -Dpartest.scalac_opts in SBT runner
#64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to pass the `-optimise` flag down to partest in PR validation builds.
|
LGTM - discussion about mima failure here: #63 (comment) |
|
@szeiger should we push a new release of scala-partest for scala/scala#5190? |
|
Ideally I'd like a new release with #54 but I suppose that'll have to wait. So let's get one out for scala/scala#5190 |
|
is there anything that blocks #54, or it just needs a review? |
|
Just the review (and now a rebase, too) |
|
i'll take a look |
szeiger
added a commit
to szeiger/scala-partest
that referenced
this pull request
Jun 14, 2016
This is required to *really* pass the `-optimise` flag down to scalac in PR validation builds. The previous change in scala#64 passed the flag to partest but partest didn’t pass the correct settings on to scalac.
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Parse `-Dpartest.scalac_opts` in SBT runner
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
This is required to *really* pass the `-optimise` flag down to scalac in PR validation builds. The previous change in scala#64 passed the flag to partest but partest didn’t pass the correct settings on to scalac.
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
Parse `-Dpartest.scalac_opts` in SBT runner
lrytz
pushed a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
This is required to *really* pass the `-optimise` flag down to scalac in PR validation builds. The previous change in scala#64 passed the flag to partest but partest didn’t pass the correct settings on to scalac.
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
May 9, 2018
This is required to *really* pass the `-optimise` flag down to scalac in PR validation builds. The previous change in scala/scala-partest#64 passed the flag to partest but partest didn’t pass the correct settings on to scalac.
lrytz
pushed a commit
to lrytz/scala
that referenced
this pull request
May 9, 2018
This is required to *really* pass the `-optimise` flag down to scalac in PR validation builds. The previous change in scala/scala-partest#64 passed the flag to partest but partest didn’t pass the correct settings on to scalac.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is required to pass the
-optimiseflag down to partest in PR validation builds (see comments in scala/scala#5190)