A trip down the rabbit hole to enable colors from sbt #54
Conversation
|
Builds failed because of binary compatibility checks, as expected. This is obviously not binary compatible but shouldn't touch the parts of partest needed by partest-extras. |
|
can you suggest a reviewer? I don't know this codebase. |
|
@adriaanm perhaps? He must have touched at least parts of this code while adding sbt support |
|
How I miss the coleurs. |
|
Let's merge this and bootstrap a new version of partest after M5. 🌈 |
- Refactored for less mutability - Narrowed scopes - Removed obsolete code
There was a choice for “many”, “some” or “none” but no way to set it. The color choices were impractical anyway (bold black foreground on standard background). Now the colors for terse output provide proper visibility and are enabled together with colored output.
szeiger
force-pushed
the
wip/config-cleanup
branch
from
e3e3a4a to
c0ec7fa
Compare
|
Rebased. Rebasing on top of #63 was a PITA. @som-snytt, can you take a look to make sure I didn't break anything? |
| @@ -6,12 +6,15 @@ | |||
| ** |/ ** | |||
| \* */ | |||
|
|
|||
| package scala.tools.partest | |||
| package nest | |||
| package scala.tools.partest.sbt | |||
There was a problem hiding this comment.
who is using this class? can we easily just move it and update its users simultaneously?
There was a problem hiding this comment.
It's used by PartestTask in the same package. This used to be in partest-interface before we moved it into partest itself.
|
LGTM otherwise. did you do some testing locally? (i didn't) |
|
@lrytz I'm pretty sure tested it locally when I wrote it. I don't remember exactly what I tested because it's been a while. |
|
@szeiger Sorry about the conflict. It would have been easier for me to rebase. I took a quick look, but I won't have more time until end of day. I'll run it later, one way or another. |
A trip down the rabbit hole to enable colors from sbt
A trip down the rabbit hole to enable colors from sbt
I set out (and succeeded) to enable color output when running from sbt. Along the way I refactored the outer layers of partest (basically everything above
SuiteRunner) to remove global mutable state and make it more manageable.