This repository was archived by the owner on Sep 8, 2022. It is now read-only.
SI-7696 Restore --show-log #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Look for the diff line in the transcript, which diffs the log file and the check file, to pick off the log file name, then just display the contents. For --show-diff output ``` \# starting 1 test in run !! 1 - run/foo.scala [output differs] % diff /home/apm/projects/snytt/test/files/run/foo-run.log /home/apm/projects/snytt/test/files/run/foo.check--- empty +++ foo-run.log @@ -1,0 +1,1 @@ +oops \# 0/1 passed, 1 failed in run ``` --show-log shows ``` \# starting 1 test in run !! 1 - run/foo.scala [output differs] \##### Log file '/home/apm/projects/snytt/test/files/run/foo-run.log' from failed test ##### oops \# 0/1 passed, 1 failed in run ``` where comment lines are prefixed by \ for purposes of commit message.
On non-zero exit, no transcript is recorded. Show log in that important use case. TestInfo encapsulates a bit of useful interface.
If a test throws (and exits non-zero), you can see the log with `--verbose` (which shows the whole transcript), `--show-log`, and now also `--show-diff` (which will show log if the other options aren't set, the test failed and there's no diff to view.
|
The last commit lets |
|
I guess Mima is the argument for folding partest back into the scala repo. |
|
not sure why we enforce binary compatibility for scala-partest. we (scala, dotty) are the only users, and we don't have any pre-compiled binaries that would link against a newly released minor version, as far as i can tell. cc @szeiger |
|
LGTM otherwise |
|
Source compatibility matters to some extent. I don't think binary compatibility does. |
|
We can merge this one too, then. |
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
SI-7696 Restore --show-log
lrytz
added a commit
to lrytz/scala-partest
that referenced
this pull request
May 9, 2018
SI-7696 Restore --show-log
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a test exits abnormally, there is no diff in the test transcript.
--show-logshows the log, which probably contains a stack trace in the case of catastrophic failure.Also, sometimes diffs are too obscure, and it's simply easier to examine the entire test output.
(That's the argument for a distinct
--show-logoption; maybe--show-diffshould show the log for abnormal completion, too.)For --show-diff output
--show-log shows