Show better error message for incorrect unicode escape sequences syntax #26782
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
bombless
force-pushed
the
unicode-escape-sequences
branch
3 times, most recently
from
95f4270 to
cdc96ac
Compare
|
Thank @niconii for the help here 😄 |
bombless
force-pushed
the
unicode-escape-sequences
branch
from
cdc96ac to
3d6afbe
Compare
| escaped_pos, | ||
| self.last_pos, | ||
| "`\\u` in string literals start unicode escape sequences; \ | ||
| for example, use `\\u{30a2}` to specify codepoint U+30A2, \ |
There was a problem hiding this comment.
Should be a separate help diagnostic.
There was a problem hiding this comment.
Thanks, I'll make it separate help message if that's needed
|
r? @pnkfelix |
bors
added a commit
that referenced
this pull request
Jul 13, 2015
Inspired by the now-mysteriously-closed #26782. This PR introduces better error messages when unicode escapes have invalid format (e.g. `\uFFFF`). It also makes rustc always tell the user that escape may not be used in byte-strings and bytes and fixes some spans to not include unecessary characters and include escape backslash in some others.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch gives better error message if the braces are missing when you use unicode escape sequences in string literals.