Show better diagnostics for unicode escapes #26947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This improves diagnostic messages when \u escape is used incorrectly and { is
missing. Instead of saying “unknown character escape: u”, it will now report
that unicode escape sequence is incomplete and suggest what the correct syntax
is.
|
r? @nrc (rust_highfive has picked a reviewer for you, use r? to override) |
| 'u' => { | ||
| let valid = if self.curr_is('{') { | ||
| let valid = self.scan_unicode_escape(delim); | ||
| if ascii_only { false } else { valid } |
There was a problem hiding this comment.
!ascii_only && self.scan_unicode_escape(delim)
|
r+ with the nits addressed |
nagisa
force-pushed
the
unicode-escape-error
branch
from
ecb8f87 to
4d65ef4
Compare
|
Comments addressed. |
|
@bors: r+ |
|
📌 Commit 4d65ef4 has been approved by |
bors
added a commit
that referenced
this pull request
Jul 13, 2015
Inspired by the now-mysteriously-closed #26782. This PR introduces better error messages when unicode escapes have invalid format (e.g. `\uFFFF`). It also makes rustc always tell the user that escape may not be used in byte-strings and bytes and fixes some spans to not include unecessary characters and include escape backslash in some others.
|
⌛ Testing commit 4d65ef4 with merge 07be629... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the now-mysteriously-closed #26782.
This PR introduces better error messages when unicode escapes have invalid format (e.g.
\uFFFF). It also makes rustc always tell the user that escape may not be used in byte-strings and bytes and fixes some spans to not include unecessary characters and include escape backslash in some others.