Skip to content

Show better error message for incorrect unicode escape sequences syntax #26782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions src/libsyntax/parse/lexer/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -742,6 +742,16 @@ impl<'a> StringReader<'a> {
valid
}
}
'u' => {
self.err_span_(
escaped_pos,
self.last_pos,
"`\\u` in string literals start unicode escape sequences; \
for example, use `\\u{30a2}` to specify codepoint U+30A2, \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be a separate help diagnostic.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'll make it separate help message if that's needed

or did you mean `\\\\u`?"
);
false
}
'\n' if delim == '"' => {
self.consume_whitespace();
true
Expand Down
15 changes: 15 additions & 0 deletions src/test/compile-fail/unicode-escape-sequences.rs
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
// Copyright 2015 The Rust Project Developers. See the COPYRIGHT
// file at the top-level directory of this distribution and at
// http://rust-lang.org/COPYRIGHT.
//
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
// option. This file may not be copied, modified, or distributed
// except according to those terms.

// Test that a covariant struct permits the lifetime of a reference to
// be shortened.

fn main() { "\u123"; }
//~^ error: `\u` in string literals start unicode escape sequences; for example, use `\u{30a2}`