Fix locally hosting docs.rs for development #216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonas-schievink
changed the title
This removes the need for things like onur/rust@482575f and allows launching a local docs.rs instance without having to build a patched compiler.
jonas-schievink
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After much debugging I noticed that docs.rs uses a patched compiler and rustdoc to generate documentation (full diff). Since compiling rustc and rustdoc is annoying, this PR adds support for unpatched toolchains by serving web resources that are shared between crates via a special handler. (the patched toolchain changed the paths so that these resources were always pulled from the root instead of a relative path)
Since this also updates the unpatched rustc toolchain installed in the VM, this closes #207