move the built cratesfyi into the vagrant container
#218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @QuietMisdreavus, but that vagrant image really needs some work. I am planning make a great return to this project really soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Works around rust-lang/rust#49710 when developing docs.rs with a Windows host.
This sets the
CARGO_TARGET_DIRenvironment variable within the vagrant box to a folder inside the container rather than in the share. This means that when building thecratesfyiexecutable or the docs.rs service, the files will be placed inside the container (in/home/cratesfyi/target) rather than in/vagrant. This does mean that the binaries will be unavailable outside the container without manually copying them out. However, without this change, any build will fail with an error like the one in the linked issue. Combined with https://github.com/onur/docs.rs/pull/216, I can fully build docs.rs from a Windows host.