Put the navigation back! #217
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes the need for things like onur/rust@482575f and allows launching a local docs.rs instance without having to build a patched compiler.
|
Hi @jonas-schievink, this is great and everything is working as expected. Thank you for bringing our navigation back. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses
html5everto parse rustdoc's output and extract the contents of<head>and<body>on each page retrieval, so it should be much more robust than the previous solution but comes at a performance cost. How large that cost is, I have no idea. Caching the output can easily bring the lost performance back (in case that isn't yet done).Built on top of #216 because I couldn't test it otherwise.