controllers/krate/search: Read downloads from crate_downloads table
#8244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8244 +/- ##
==========================================
- Coverage 87.74% 87.74% -0.01%
==========================================
Files 273 273
Lines 27345 27354 +9
==========================================
+ Hits 23994 24001 +7
- Misses 3351 3353 +2 ☔ View full report in Codecov by Sentry. |
Turbo87
force-pushed
the
search-downloads
branch
from
c02e090 to
ef105ce
Compare
eth3lbert
approved these changes
Mar 5, 2024
LawnGnome
approved these changes
Mar 6, 2024
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on top of #8232 and switches our
GET /api/v1/cratesendpoint over to using thecrate_downloadstable instead of thecrates.downloadscolumn.Performance tests on the production replica database indicated that this should not significantly affect the performance of the endpoint (see https://rust-lang.zulipchat.com/#narrow/stream/318791-t-crates-io/topic/.60crate_downloads.60.20table).
This should allow us to eventually remove the
crates.downloadscolumn, reducing the number of writes to thecratestable.