controllers/user/other: Read downloads from crate_downloads table
#8250
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turbo87
added
C-internal 🔧
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8250 +/- ##
=======================================
Coverage 87.74% 87.74%
=======================================
Files 273 273
Lines 27354 27360 +6
=======================================
+ Hits 24001 24007 +6
Misses 3353 3353 ☔ View full report in Codecov by Sentry. |
eth3lbert
reviewed
Mar 6, 2024
Comment on lines
-32
to
40
| let data: i64 = CrateOwner::by_owner_kind(OwnerKind::User) | ||
| let data = CrateOwner::by_owner_kind(OwnerKind::User) | ||
| .inner_join(crates::table) | ||
| .inner_join(crate_downloads::table.on(crates::id.eq(crate_downloads::crate_id))) | ||
| .filter(crate_owners::owner_id.eq(user_id)) | ||
| .select(sum(crates::downloads)) | ||
| .first::<Option<i64>>(conn)? | ||
| .select(sum(crate_downloads::downloads)) | ||
| .first::<Option<BigDecimal>>(conn)? | ||
| .map(|d| d.to_u64().unwrap_or(u64::MAX)) | ||
| .unwrap_or(0); |
There was a problem hiding this comment.
Just leaving information here. Due to the fact that the sum function over bigint columns in PostgreSQL returns numeric (sum ( bigint ) → numeric), I believe this is the reason we use BigDecimal here instead of i64.
There was a problem hiding this comment.
yeah, exactly. Diesel has the same behavior built into the typesystem, which is why I had to change it like this
eth3lbert
approved these changes
Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is roughly similar to #8244 and switches the
/api/v1/users/:user_id/statsendpoint over to using thecrate_downloadsdatabase table instead of thecrates.downloadscolumn.