Skip to content

controllers/krate/metadata: Read downloads from crate_downloads table #8253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 6, 2024

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Mar 6, 2024

This is roughly similar to #8244 and switches the /api/v1/crates/:crate_id endpoint over to using the crate_downloads database table instead of the crates.downloads column.

@Turbo87 Turbo87 added C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear A-backend ⚙️ labels Mar 6, 2024
@Turbo87 Turbo87 requested a review from a team March 6, 2024 08:48
Copy link
Contributor

@eth3lbert eth3lbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, and my comment is not a blocker.

@Turbo87 Turbo87 force-pushed the crate-details-downloads branch from e9e5f53 to 81ce5b6 Compare March 6, 2024 19:25
@Turbo87 Turbo87 enabled auto-merge (squash) March 6, 2024 19:30
@Turbo87 Turbo87 merged commit 74892ed into rust-lang:main Mar 6, 2024
@Turbo87 Turbo87 deleted the crate-details-downloads branch March 6, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-backend ⚙️ C-internal 🔧 Category: Nonessential work that would make the codebase more consistent or clear
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants