-
Notifications
You must be signed in to change notification settings - Fork 9
perf: remove unnecessary cloning and iteration #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rubensworks
merged 18 commits into
rubensworks:master
from
jeswr:perf/no-unnecessary-parent-calc
Nov 7, 2023
Merged
perf: remove unnecessary cloning and iteration #73
rubensworks
merged 18 commits into
rubensworks:master
from
jeswr:perf/no-unnecessary-parent-calc
Nov 7, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Pull Request Test Coverage Report for Build 6706243153
💛 - Coveralls |
jeswr
commented
Oct 29, 2023
rubensworks
requested changes
Oct 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice optimization work @jeswr!
rubensworks
requested changes
Oct 31, 2023
Impressive work @jeswr! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
@import
statement (fix: deep copy imported contexts #71 was originally opened to resolve this).All unit & spec tests in the
jsonld-streaming-parser
pass with these changes (tested against bce9e05).I have also done a (small) benchmark of these changes. As can be seen the time taken to parse a context with these changes significantly decreases (in particular it is now 20x faster to parse a VC context).
Before:
Parse a context that has not been cached; and without caching in place x 78.17 ops/sec ±0.73% (78 runs sampled)
Parse a context object that has not been cached x 2,280 ops/sec ±0.65% (91 runs sampled)
in #72:
Parse a context that has not been cached; and without caching in place x 123 ops/sec ±0.78% (84 runs sampled)
Parse a context object that has not been cached x 5,417 ops/sec ±0.70% (87 runs sampled)
After (in this PR):
Parse a context that has not been cached; and without caching in place x 1,714 ops/sec ±0.78% (84 runs sampled)
Parse a context object that has not been cached x 8,902 ops/sec ±0.70% (87 runs sampled)
Let's get this merged and then I'll revisit #70 to see what is actually worth caching.