perf: no deep cloning #72
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6679792446
💛 - Coveralls |
jeswr
commented
Oct 28, 2023
|
Closing in favor of #73 |
rubensworks
pushed a commit
that referenced
this pull request
Nov 7, 2023
This significantly improves parsing performance. I have also done a (small) benchmark of these changes. As can be seen the time taken to parse a context with these changes significantly decreases (in particular it is now 20x faster to parse a VC context). Before: Parse a context that has not been cached; and without caching in place x 78.17 ops/sec ±0.73% (78 runs sampled) Parse a context object that has not been cached x 2,280 ops/sec ±0.65% (91 runs sampled) in #72: Parse a context that has not been cached; and without caching in place x 123 ops/sec ±0.78% (84 runs sampled) Parse a context object that has not been cached x 5,417 ops/sec ±0.70% (87 runs sampled) After (in this PR): Parse a context that has not been cached; and without caching in place x 1,714 ops/sec ±0.78% (84 runs sampled) Parse a context object that has not been cached x 8,902 ops/sec ±0.70% (87 runs sampled)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative to #71 which removes the need for any deep cloning.
All unit & spec tests in the
jsonld-streaming-parserpass with these changes.I have also done a (small) benchmark of these changes. As can be seen the time taken to parse a context with these changes significantly decreases.
Before:
Parse a context that has not been cached; and without caching in place x 78.17 ops/sec ±0.73% (78 runs sampled)
Parse a context object that has not been cached x 2,280 ops/sec ±0.65% (91 runs sampled)
After:
Parse a context that has not been cached; and without caching in place x 123 ops/sec ±0.78% (84 runs sampled)
Parse a context object that has not been cached x 5,417 ops/sec ±0.70% (87 runs sampled)