Skip to content

fix: deep copy imported contexts #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: deep copy imported contexts #71

wants to merge 1 commit into from

Conversation

jeswr
Copy link
Contributor

@jeswr jeswr commented Oct 28, 2023 •
edited
Loading

If we don't clone then we mutate cached document contexts; and contexts which may use the input context later on.

@coveralls
Copy link

coveralls commented Oct 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6679282495

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%
Totals Coverage Status
Change from base Build 6492290900: 0.0%
Covered Lines: 543
Relevant Lines: 543
💛 - Coveralls

@jeswr jeswr marked this pull request as draft October 28, 2023 21:15
@jeswr jeswr force-pushed the fix/deep-copy-imported-contexts branch from a1e44da to 3f8c98f Compare October 28, 2023 21:18
@jeswr jeswr marked this pull request as ready for review October 28, 2023 21:19
@jeswr jeswr mentioned this pull request Oct 28, 2023
Closed
@jeswr
Copy link
Contributor Author

jeswr commented Oct 29, 2023

Closing in favor of #73.

@jeswr jeswr closed this Oct 29, 2023
@jeswr jeswr mentioned this pull request Oct 29, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jeswr @coveralls