Skip to content

Remove old Ruby version from CI config & cross build rake task #455

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aharpervc
Copy link
Contributor

This is a prerequisite for #434 (per comment). It's effectively a followup to #428.

Adding recent contributors for review.

@aharpervc aharpervc self-assigned this Jan 31, 2020
@aharpervc aharpervc requested a review from larskanis January 31, 2020 18:40
@aharpervc
Copy link
Contributor Author

@larskanis looks like you were also doing this work here: master...larskanis:update-windows-binary, was there a blocker on that?

@jrgns
Copy link

jrgns commented Feb 4, 2020

Can we perhaps add support for Ruby 2.7 while we're at it?

@aharpervc
Copy link
Contributor Author

Can we perhaps add support for Ruby 2.7 while we're at it?

I don't see why not

@larskanis
Copy link
Member

@aharpervc I don't remember what interrupted me. Nevertheless you need to update rake-compiler-dock to 1.0 in order to cross build for Ruby-2.7. OpenSSL-1.1.1 should work as well. We cross build it in ruby-pg.

@larskanis
Copy link
Member

Appveyor seems to be disabled for this repository. The badge icon in the README shows the last build two years ago.

@aharpervc
Copy link
Contributor Author

Great @larskanis thanks for the tip. I removed the old appveyor config and updated rake-compiler-dock & the default OpenSSL version.

@aharpervc
Copy link
Contributor Author

The 2.7 job is failing because tiny tds can't find the freetds headers (I think...) indicated by this right before the final error:

checking for sybfront.h... no
checking for sybdb.h... no
checking for tdsdbopen() in -lsybdb... no
checking for dbanydatecrack() in -lsybdb... no

However, I don't know why that would be. Freetds appears to install without problem, and diffing the 2.6 & 2.7 job logs that part of each job seems to be similar. @larskanis ideas?

@aharpervc
Copy link
Contributor Author

aharpervc commented Feb 7, 2020

Given that 2.7 is requires additional changes, I'm going to slice that work out to another branch so we can get the main stuff merged.

@larskanis
Copy link
Member

@aharpervc Couldn't you reactivate Appveyor-CI instead of dropping it? That would make sure, that the gem is properly working on Windows. Or is there a particular reason to not use Appveyor any longer?

@aharpervc aharpervc force-pushed the sync-cross-compile-and-ci-config branch from ae44521 to e75a379 Compare February 7, 2020 15:17
@aharpervc
Copy link
Contributor Author

aharpervc commented Feb 7, 2020

Or is there a particular reason to not use Appveyor any longer?

I feel like I asked this question somewhere on this repo a long time ago, and there was an answer, but I can't recall what it was & I can't find my question.

I'm open to adding more CI config, especially for Windows. Whether that would be back to appveyor or some other service is an open question to me. Travis has Windows support now I believe, and CircieCI supports Linux/macOS/Windows and might be a better choice overall. Azure Devops also supports all OS's. Github Actions can be used for CI and also supports everything. There's lots to consider.

@MadsNielsen
Copy link

Hey @aharpervc is there any change we might soon see a new release of this gem with the support for 2.6 and precompiled windows gems?

@aharpervc
Copy link
Contributor Author

I hope so, although this branch has been superseded by #456

@aharpervc aharpervc merged commit e75a379 into rails-sqlserver:master Feb 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants