Skip to content

Upgrade OpenSSL to next minor version 1.1.0j #428

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

sukeerthiadiga
Copy link
Contributor

@sukeerthiadiga sukeerthiadiga commented Feb 18, 2019

  • OpenSSL 1.1.0e -> 1.1.0j
  • Change travis-ci config file to pick specific version of bundler.
  • Added 2.4, 2.5 and 2.6 ruby versions for testing.

@sukeerthiadiga sukeerthiadiga force-pushed the topic/sukeeerthiadiga/upgrade-openssl branch from d95d184 to aabad7c Compare February 18, 2019 07:43
@sukeerthiadiga
Copy link
Contributor Author

@metaskills by any chance can we merge this.
Credits to @nzdjb. I have pulled his code to fix the build.

@aharpervc
Copy link
Contributor

aharpervc commented Feb 20, 2019

If you're going to spend the time to reconfigure the build matrix as a prereq for upgrading openssl, I think we should take that opportunity to drop testing for 2.1 (EOL'd 2017-03-31) and 2.2 (EOL'd 2018-03-31). Even 2.3 EOL's 2019-03-31, but I guess we can keep it for now. And then we should probably ensure that 2.4 and 2.5 are tested, and ideally 2.6 as well.

@sukeerthiadiga
Copy link
Contributor Author

If you're going to spend the time to reconfigure the build matrix as a prereq for upgrading openssl, I think we should take that opportunity to drop testing for 2.1 (EOL'd 2017-03-31) and 2.2 (EOL'd 2018-03-31). Even 2.3 EOL's 2019-03-31, but I guess we can keep it for now. And then we should probably ensure that 2.4 and 2.5 are tested, and ideally 2.6 as well.

This totally makes sense to me. I have added latest 2.4.x, 2.5.x and 2.6.x ruby versions. We should be good now.

@wpolicarpo
Copy link
Member

I agree we should drop ruby 2.1 and 2.2 from the matrix. In the end, updating the rvm matrix values was enough.

@nzdjb
Copy link

nzdjb commented Feb 20, 2019

I'm going to close out PR#424 in favour of this.

@nzdjb nzdjb mentioned this pull request Feb 20, 2019
nzdjb and others added 4 commits February 21, 2019 12:33
As all the supported rubies now work with Bundler 2, the install instructions are the same for each and so can be condensed down to the simpler format again.
As the supported Rubies are changing in the Travis config, they should change in the Appveyor config too.
Move back to simpler syntax for defining supported Rubies.
Change the appveyor matrix to represent supported rubies.
@wpolicarpo wpolicarpo merged commit 7081112 into rails-sqlserver:master Feb 25, 2019
aharpervc pushed a commit to aharpervc/tiny_tds that referenced this pull request Apr 9, 2020
Upgrade OpenSSL to next minor version 1.1.0j
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants