Update cross build, Travis and Appveyor-CI #456

larskanis · 2020-02-09T21:56:48Z

This PR includes #455 . It adds ruby versions 2.6 and 2.7 to Windows binary gems and updates and fixes Appveyor and Travis CI. It also adds ruby-head to Appveyor-CI. It removes rubies before 2.4 and some necessary workarounds. OpenSSL and FreeTDS are updated to the latest release versions.

Appveyor needs to be re-enabled for this repository to be effective.

- Add Ruby-head version - Remove outdated ruby versions - Decrease number of ruby versions, so that tests run faster - Run all tests, even when a test fails

- Add Ruby-head version - Remove outdated ruby versions - Decrease number of ruby versions, so that tests run faster - Run all tests, even when a test fails - Make use of Appveyors dual core CPUs

…is/tiny_tds into sync-cross-compile-and-ci-config

This fixes broken 32 bit build on Appveyor-CI. Also print config.log to ease debugging.

aharpervc

Thanks for spending some time to get this working.

aharpervc · 2020-02-10T15:08:07Z

appveyor.yml

    - ruby_version: "26"
+    - ruby_version: "head-x64"


Some of the changes to this matrix list are surprising:

why remove 24-x64, 25, and 26-x64? If it's for overall speed concerns, I'd think that the ongoing verification is preferable to saving a few minutes per PR

any limit against adding ruby 2.7?

personally, I don't think testing against head builds is necessary, but I'm not opposed to it

I removed some Ruby versions because one CI run takes almost two hours otherwise and testing all Ruby versions on add architectures has little value. Errors that affect only a single Ruby version on a single architecture are very rare.

Ruby-2.7 is not yet available in appveyor.

Testing on Ruby head is good to get early hints about incompatibilities or deprecations.

CI run takes almost two hours

Yeouch, I didn't know it was that bad.... I'm on board with slimming down the list then. Also this & the fact that it's so slow is making me want to revisit our overall CI config (later....)

aharpervc · 2020-02-10T15:09:40Z

ext/tiny_tds/extconf.rb

 freetds_ports_dir = File.join(project_dir, 'ports', host, 'freetds', FREETDS_VERSION)
 freetds_ports_dir = File.expand_path(freetds_ports_dir)

 # Add all the special path searching from the original tiny_tds build
-# order is important here! First in, last searched.
+# order is important here! First in, first searched.


Curious for my own understanding, why was it this order worked in the past but is now a problem?

Previously we used a side effect of calling dir_config multiple times. This doesn't work any longer on Ruby-2.7.

I see, thanks for explaining. Is it odd in retrospect that we were calling dir_config in a loop rather than setting up the directories in the right order?

I think so.

aharpervc · 2020-02-13T16:58:11Z

This seems fine with me to merge

larskanis · 2020-02-25T15:14:35Z

@aharpervc Can you merge this? You should have the permission to do so. However you don't seem to have permissions to release tiny_tds on rubygems.org. @metaskills Could you add @aharpervc to rubygems.org? Any other opinions?

metaskills · 2020-02-25T16:07:10Z

@metaskills Could you add @aharpervc to rubygems.org? Any other opinions?

I can add anyone needed to ruby gems. I just need their email address. You can DM this on Twitter (same metaskills user name) if y'all want or obfuscate it here too.

aharpervc · 2020-02-25T16:13:48Z

@aharpervc Can you merge this? You should have the permission to do so.

Happy to, although I assumed you could as well since you're listed as a member?

I can add anyone needed to ruby gems. I just need their email address. You can DM this on Twitter (same metaskills user name) if y'all want or obfuscate it here too.

I just emailed you

larskanis · 2020-02-25T18:50:19Z

Happy to, although I assumed you could as well since you're listed as a member?

Sure, but I'd like to stay a contributor only and don't want to maintain a project, that I use rarely. I'm glad if you could do maintenance, if Ken doesn't have the time to.

metaskills · 2020-02-25T18:57:44Z

The only thing I have time for is to help others adopt and service this project. Just point me to who needs perms and where :)

aharpervc · 2020-02-25T21:21:18Z

Well I expected appveyor to run the job when I merged this PR, but it doesn't look like that happened: https://ci.appveyor.com/project/rails-sqlserver/tiny-tds/history

Something might need to get turned on over there, but if so I don't have access

metaskills · 2020-02-26T12:08:45Z

I approved the Appveyor addition. Let me know if I can do anything else.

aharpervc · 2020-03-02T14:59:50Z

Looks like something is missing as I am still not seeing a new version on https://rubygems.org/gems/tiny_tds/versions or is there a delay before it shows up @aharpervc ?

No new version has been published yet, because no new version has been prepared yet, because appveyor isn't running the tests yet, because of some unknown reason. I hope to be able to revisit that question this week.

larskanis · 2020-03-02T16:24:11Z

I just added #459, but Appveyor is still not running on the repository.
@metaskills , @aharpervc Did you add tiny_tds as new project here? https://ci.appveyor.com/projects/new

aharpervc · 2020-03-02T16:37:58Z

No, but that may be due to a problem on my end... Appveyor wants to "Authorize as GitHub App" or "Authorize as OAuth App", and I'm not sure what the implications are for this org/repo. Which one did you pick?

larskanis · 2020-03-03T08:27:07Z

@aharpervc I think "Authorize as GitHub App".

aharpervc · 2020-03-03T14:49:50Z

@aharpervc I think "Authorize as GitHub App".

Alright, I gave that a try. It looks like the request will need to be approved by a rails-sqlserver org admin

metaskills · 2020-03-03T16:33:36Z

I think I just authorized that.

aharpervc · 2020-03-03T16:43:42Z

Thanks, I tried to complete the process by adding Appveyor to this repo, but then I got an error saying it can only be done by an org owner:

metaskills · 2020-03-06T12:07:12Z

OK, I just invited you as an admin to our Appveyor account. From there you can authorize it via your account. Reminder, Microsoft still pays for this account too and it looks like the CC is valid till 2021 too.

aharpervc · 2020-03-06T15:28:46Z

Thanks, I can now see the tiny_tds project.

From the events log it seems that appveyor was notified when this PR was merged to master, but declined to run the job due to not finding appveyor.yml (which is odd because it definitely is right there).

I suspect appveyor might be looking at an outdated version of the repo, because when I tried to just have it run a build manually, I got this error:

I'm not sure what credentials it might be trying, so I returned to the authorizations page here: https://ci.appveyor.com/account/rails-sqlserver/authorizations and tried to run "Authorize as GitHub App" as described above, but again got the error This action must be performed by an organization owner.

@metaskills I think you might need to click that install button in appveyor to get it to reconnect to this repo, can you review that when you have a moment?

metaskills · 2020-03-06T16:45:45Z

Thanks, we are getting close. I did not want to click it because it would get access to Custom Ink's account too. So I just changed you to an org owner too.

metaskills · 2020-03-06T16:46:28Z

@wpolicarpo Just made you an org owner as well.

aharpervc · 2020-03-06T17:37:12Z

Alright I was able to start the build manually, and it grabbed the latest code from master and is building right now.

MadsNielsen · 2020-03-26T09:51:32Z

Same. We're also depending heavily on this gem. @aharpervc

aae42 · 2020-04-01T15:29:25Z

is anyone still working on this? so close!

aharpervc · 2020-04-01T16:20:21Z

I will revisit this and try to cut a new release this week or next week, if I can

vifrac · 2020-04-02T17:31:22Z

I will revisit this and try to cut a new release this week or next week, if I can

Hey, very thanks for your work, I too wait for this update

Reppinger · 2020-04-07T20:48:44Z

Thanks to all who contributed. I will temporarily roll back to ruby 2.5 which causes me no problems right now. Looking forward to going back to 2.6. Thanks, @aharpervc !

ecentell-CPF · 2020-04-14T14:10:53Z

Thank you for #462 and i can see it up on https://rubygems.org/gems/tiny_tds/versions/2.1.3.pre-x64-mingw32 !

aharpervc · 2020-09-29T14:02:54Z

It took awhile, but 2.1.3 has now been released

aharpervc and others added 10 commits February 7, 2020 10:14

Remove old Ruby versions from CI config & cross compile rake task

5da8f76

Add Ruby 2.6 to the cross compile list

33d2189

Update readme

e75a379

Add ruby-2.7 to cross build and tests, Update freetds and OpenSSL

ab25833

Update Appveyor-CI

dcc8731

- Add Ruby-head version - Remove outdated ruby versions - Decrease number of ruby versions, so that tests run faster - Run all tests, even when a test fails

Update Appveyor-CI

6299be6

- Add Ruby-head version - Remove outdated ruby versions - Decrease number of ruby versions, so that tests run faster - Run all tests, even when a test fails - Make use of Appveyors dual core CPUs

Update rake to fix compat with ruby-head

a18a275

Fix cross build for binary Windows gems

42f90a7

Merge branch 'sync-cross-compile-and-ci-config' of github.com:larskan…

a8e617e

…is/tiny_tds into sync-cross-compile-and-ci-config

Prevent freetds to link to wrong ws2_32 lib on i686-w64-mingw32

a35ac89

This fixes broken 32 bit build on Appveyor-CI. Also print config.log to ease debugging.

aharpervc reviewed Feb 10, 2020

View reviewed changes

This was referenced Feb 18, 2020

Working only with Ruby < 2.6 #458

Closed

Remove old Ruby version from CI config & cross build rake task #455

Merged

aharpervc merged commit 7fb8580 into rails-sqlserver:master Feb 25, 2020

lambacck mentioned this pull request Oct 31, 2021

Update CI/Cross compile Ruby version support #509

Closed

Update cross build, Travis and Appveyor-CI #456

Update cross build, Travis and Appveyor-CI #456

Uh oh!

Conversation

larskanis commented Feb 9, 2020

Uh oh!

aharpervc left a comment

Choose a reason for hiding this comment

Uh oh!

aharpervc Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

larskanis Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

aharpervc Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

aharpervc Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

larskanis Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

aharpervc Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

larskanis Feb 10, 2020

Choose a reason for hiding this comment

Uh oh!

aharpervc commented Feb 13, 2020

Uh oh!

larskanis commented Feb 25, 2020

Uh oh!

metaskills commented Feb 25, 2020

Uh oh!

aharpervc commented Feb 25, 2020

Uh oh!

larskanis commented Feb 25, 2020

Uh oh!

metaskills commented Feb 25, 2020

Uh oh!

aharpervc commented Feb 25, 2020

Uh oh!

metaskills commented Feb 26, 2020

Uh oh!

aharpervc commented Mar 2, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

larskanis commented Mar 2, 2020

Uh oh!

aharpervc commented Mar 2, 2020

Uh oh!

larskanis commented Mar 3, 2020

Uh oh!

aharpervc commented Mar 3, 2020

Uh oh!

metaskills commented Mar 3, 2020

Uh oh!

aharpervc commented Mar 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

metaskills commented Mar 6, 2020

Uh oh!

aharpervc commented Mar 6, 2020

Uh oh!

metaskills commented Mar 6, 2020

Uh oh!

metaskills commented Mar 6, 2020

Uh oh!

aharpervc commented Mar 6, 2020

Uh oh!

MadsNielsen commented Mar 26, 2020

Uh oh!

aae42 commented Apr 1, 2020

Uh oh!

aharpervc commented Apr 1, 2020

Uh oh!

vifrac commented Apr 2, 2020

Uh oh!

aharpervc commented Mar 2, 2020 •

edited

Loading

aharpervc commented Mar 3, 2020 •

edited

Loading