Update user-defined triton kernels tutorial with new torch.library.triton_op #3227

zou3519 · 2025-01-10T16:58:52Z

The new API is a more advanced complement to the existing APIs.

cc @williamwen42 @msaroufim @anijain2305

pytorch-bot · 2025-01-10T16:58:57Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3227

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

This comment was automatically generated by Dr. CI and updates every 15 minutes.

…iton_op The new API is a more advanced complement to the existing APIs.

oulgen · 2025-01-10T17:48:11Z

recipes_source/torch_compile_user_defined_triton_kernel_tutorial.py

+# >>>     y = mysin(x)
+
+######################################################################
+# Limitations


Having this title be limitations, and then having two paragraphs of not-limitations is a bit weird

svekars

Thanks, @zou3519! I added a few editorial suggestions.

recipes_source/torch_compile_user_defined_triton_kernel_tutorial.py

…al.py

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

recipes_source/torch_compile_user_defined_triton_kernel_tutorial.py

…al.py

svekars

LGTM! We should wait for the 2.6 stable binaries to be available in main and merge into main (~ end of Jan).

davidberard98 · 2025-01-15T18:38:14Z

recipes_source/torch_compile_user_defined_triton_kernel_tutorial.py

+def sin_triton(x):
+    out = torch.empty_like(x)
+    n_elements = x.numel()
+    sin_kernel[(n_elements,)](x, out, n_elements, BLOCK_SIZE=4)
+    return out


I guess this is the user-defined triton kernel w/ no @triton_op ? imo it would make sense to remove it (or add some context around it to indicate that this is the alternative where you don't use @triton_op)

kit1980 · 2025-01-23T00:15:42Z

Should we land this?
I'd want to link to this in the 2.6 release blog.

svekars · 2025-01-23T16:47:12Z

Will be landing everything on Friday and will provide links.

facebook-github-bot added the cla signed label Jan 10, 2025

zou3519 requested review from oulgen, davidberard98 and svekars January 10, 2025 16:59

Update user-defined triton kernels tutorial with new torch.library.tr…

c307876

…iton_op The new API is a more advanced complement to the existing APIs.

zou3519 force-pushed the update_triton branch from b409fec to c307876 Compare January 10, 2025 17:05

oulgen reviewed Jan 10, 2025

View reviewed changes

oulgen approved these changes Jan 10, 2025

View reviewed changes

svekars added the 2.6 Tracking 2.6 version PRs. label Jan 10, 2025

svekars reviewed Jan 10, 2025

View reviewed changes

svekars changed the base branch from main to 2.6-RC-TEST January 10, 2025 18:09

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

5b03d04

…al.py

svekars added the torch.compile Torch compile and other relevant tutorials label Jan 13, 2025

zou3519 and others added 16 commits January 13, 2025 14:34

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

dd359f7

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

20e86d0

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

72d6007

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

58bc83d

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

665cd6e

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

4f9eede

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

e5aaa9a

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

9de60b4

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

a165a7e

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

3620928

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

e8c6763

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

cbe7f04

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

844ff02

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

7b0fb12

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

db1c64e

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

a88cf38

…al.py Co-authored-by: Svetlana Karslioglu <svekars@meta.com>

svekars reviewed Jan 13, 2025

View reviewed changes

recipes_source/torch_compile_user_defined_triton_kernel_tutorial.py Outdated Show resolved Hide resolved

Update recipes_source/torch_compile_user_defined_triton_kernel_tutori…

bc9c98e

…al.py

svekars approved these changes Jan 13, 2025

View reviewed changes

davidberard98 approved these changes Jan 15, 2025

View reviewed changes

svekars changed the base branch from 2.6-RC-TEST to main January 24, 2025 18:23

svekars added 2 commits January 24, 2025 10:23

Merge branch 'main' into update_triton

9291e85

Merge branch 'main' into update_triton

2ee6553

svekars merged commit c27636a into main Jan 24, 2025
17 of 18 checks passed

svekars deleted the update_triton branch January 24, 2025 20:26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update user-defined triton kernels tutorial with new torch.library.triton_op #3227

Update user-defined triton kernels tutorial with new torch.library.triton_op #3227

Uh oh!

zou3519 commented Jan 10, 2025 •

edited by pytorch-bot bot

Loading

Uh oh!

pytorch-bot bot commented Jan 10, 2025 •

edited

Loading

Uh oh!

oulgen Jan 10, 2025

Uh oh!

svekars left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svekars left a comment

Uh oh!

davidberard98 Jan 15, 2025

Uh oh!

kit1980 commented Jan 23, 2025

Uh oh!

svekars commented Jan 23, 2025

Uh oh!

Uh oh!

Uh oh!

Update user-defined triton kernels tutorial with new torch.library.triton_op #3227

Update user-defined triton kernels tutorial with new torch.library.triton_op #3227

Uh oh!

Conversation

zou3519 commented Jan 10, 2025 • edited by pytorch-bot bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pytorch-bot bot commented Jan 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3227

Uh oh!

oulgen Jan 10, 2025

Choose a reason for hiding this comment

Uh oh!

svekars left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svekars left a comment

Choose a reason for hiding this comment

Uh oh!

davidberard98 Jan 15, 2025

Choose a reason for hiding this comment

Uh oh!

kit1980 commented Jan 23, 2025

Uh oh!

svekars commented Jan 23, 2025

Uh oh!

Uh oh!

Uh oh!

zou3519 commented Jan 10, 2025 •

edited by pytorch-bot bot

Loading

pytorch-bot bot commented Jan 10, 2025 •

edited

Loading