(wip) use json, not pson, steal Bens work to make pup4 #1087
Conversation
|
fwiw, these are failing on lint checks not tests
I've heard at least someone express a preference for making this replace the existing method rather than deprecating the old and replacing it with a "stdlib::" namespaced one. I'm unclear if we should then remove the stricter type checking? Do others have thoughts on the approach? |
|
Hi @justinstoller, Depending on how much the behaviour changes, it might be a barrier to switching over. I'm not familiar enough with the pson/json differences to be able to make a judgement call on that. I would guess that most users of those functions are actually looking for JSON, not pson semantics, so it might be really not a big deal in this case. With the changes in #1079 we're moving all non-deprecated functions to cc @binford2k |
| URI_WITH_NAME_PATTERN = %r{(http\://|https\://)(.*)@(.*)} | ||
|
|
||
| dispatch :default_impl do | ||
| param 'String', :path_or_uri |
There was a problem hiding this comment.
Could we use Stdlib::HTTP(s)Url here?
There was a problem hiding this comment.
It needs to be a URL or filepath that Ruby will accept. Maybe we could do something like:
dispatch :load_from_uri do
param 'Variant[Stdlib::HttpsUrl, Stdlib::HttpUrl]', :url
...
dispatch :load_from_file do
param 'Stdlib::Absolutepath', :path
...There was a problem hiding this comment.
I tried something in d584063 I don't know if it's correct, still need to test it. But is it more what you were thinking?
Needs tests and to double check the documentation / its generation.
Wanted to know if there were any concerns with the approach though.
FWIW, I first tried to overwrite the existing method but we have tests that invalid inputs cause the default given to be output instead of failing with a type error (which the newer functions would do if properly typed).
Alternatively, I could loosen the typing to allow more backwards compat but there'll still be some incompatibility between JSON <-> PSON. The content of the 4x functions was stolen from Ben's PR #1079 and slightly cleaned up.