(MODULES-1882, IAC-114) move all function implementations to puppet4 API

* move all functions to `stdlib::` prefix
* fix internal function calls
* adjust test suite to test the correct functions
* adjust test suite to use puppet4 semantics
* reinstate deprecated functions in their original form - we don't want to rock that boat more than necessary
* un-deprecate `is_function_available` as there is no comparable function elsewhere
* properly deprecate `upcase`, `values` as they are real puppet6 functions

TODO:

* add backwards compatible shims for everything that moved to the `stdlib::` prefix. This can be used LATER to add a deprecation warning
* fix the documentation on all migrated functions
* add deprecation warnings for anything "weird":
** convert manual type-checking to type annotations
** deprecate non-plain types
** unused varargs (lots of functions allow infinite args, but will only use the first few)
** remove manual arg-length checking
** remove unused `require`s

Author: DavidS

lib/puppet/functions/is_absolute_path.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_absolute_path) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_array.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_array) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_bool.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_bool) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_float.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_float) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_ip_address.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_ip_address) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_ipv4_address.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_ipv4_address) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_ipv6_address.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_ipv6_address) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_numeric.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_numeric) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/is_string.rb

@@ -1,5 +1,5 @@
 # @summary
-#   Wrapper that calls the Puppet 3.x funtion of the same name.
+#   Wrapper that calls the Puppet 3.x function of the same name.
 Puppet::Functions.create_function(:is_string) do
   # @param scope
   #   The main value that will be passed to the wrapped method

lib/puppet/functions/stdlib/abs.rb

@@ -68,12 +68,12 @@ def default_impl(*arguments)
                   end
 
     if arg.is_a?(Numeric)
-      return function_num2bool([arguments[0]])
+      return call_function('stdlib::num2bool', arguments[0])
     end
 
     if arg.is_a?(String)
-      return function_num2bool([arguments[0]]) if valid_float
-      return function_str2bool([arguments[0]])
+      return call_function('stdlib::num2bool', arguments[0]) if valid_float
+      return call_function('stdlib::str2bool', arguments[0])
     end
 
     true

lib/puppet/functions/stdlib/any2bool.rb

@@ -38,15 +38,14 @@
   def default_impl(*args)
     raise(Puppet::ParseError, "assert_private(): Wrong number of arguments given (#{args.size}}) for 0 or 1)") if args.size > 1
 
-    scope = self
-    return unless scope.lookupvar('module_name') != scope.lookupvar('caller_module_name')
+    return unless closure_scope['module_name'] != closure_scope['caller_module_name']
 
     message = nil
     if args[0] && args[0].is_a?(String)
       message = args[0]
     else
-      manifest_name = scope.source.name
-      manifest_type = scope.source.type
+      manifest_name = closure_scope.source.name
+      manifest_type = closure_scope.source.type
       message = (manifest_type.to_s == 'hostclass') ? 'Class' : 'Definition'
       message += " #{manifest_name} is private"
     end

lib/puppet/functions/stdlib/assert_private.rb

@@ -54,7 +54,7 @@
   def default_impl(*arguments)
     raise(Puppet::ParseError, "bool2num(): Wrong number of arguments given (#{arguments.size} for 1)") if arguments.empty?
 
-    value = function_str2bool([arguments[0]])
+    value = call_function('stdlib::str2bool', *arguments)
 
     # We have real boolean values as well ...
     result = value ? 1 : 0