Puppet 4 functions

[binford2k]

Recreating #1078 with a fork and rubocop fixes.

[codecov-io]

Codecov Report

Merging #1079 into master will decrease coverage by 1.68%.
The diff coverage is 0%.

@@            Coverage Diff            @@
##           master   #1079      +/-   ##
=========================================
- Coverage    4.54%   2.86%   -1.69%     
=========================================
  Files         183     319     +136     
  Lines        5238    8104    +2866     
=========================================
- Hits          238     232       -6     
- Misses       5000    7872    +2872

Impacted Files	Coverage Δ
lib/puppet/functions/stdlib/str2saltedsha512.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/uriescape.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/values_at.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/delete.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/join.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/rstrip.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/floor.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/validate_bool.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/is_ipv6_address.rb	0% <0%> (ø)
lib/puppet/functions/stdlib/validate_re.rb	0% <0%> (ø)
... and 265 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1e2e0b...f1ef935. Read the comment docs.

[DavidS]

I've started some work to finalise this in https://github.com/DavidS/puppetlabs-stdlib/tree/modules-1882-move-function-api and https://tickets.puppetlabs.com/browse/IAC-114

[michaeltlombardi]

@DavidS you're on vacation so don't answer this til you get back, but can this PR be closed in favor of forward movement in IAC-114?

[timhughes]

Given that V3 support was dropped in 2019, should this function be kept or dropped 9e8ce94#diff-12e598daecade60b04e493f45c134fec9287ac7471114d95d1995b4fb651a6c8

[pmcmaw]

@binford2k There is more work to be done on this.
Due to backwards incompatibility, this is something that we will need to plan and schedule priorities.

This comment is in relation to both this PR and @DavidS WIP PR mentioned above: https://github.com/DavidS/puppetlabs-stdlib/tree/modules-1882-move-function-api

Also this is the ticket in relation to this: https://tickets.puppetlabs.com/browse/IAC-114

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 0% with 2878 lines in your changes missing coverage. Please review.

Project coverage is 2.86%. Comparing base (f1e2e0b) to head (f1ef935).

Files with missing lines	Patch %	Lines
lib/puppet/functions/stdlib/validate_integer.rb	0.00%	66 Missing ⚠️
lib/puppet/functions/stdlib/validate_numeric.rb	0.00%	66 Missing ⚠️
lib/puppet/functions/stdlib/validate_augeas.rb	0.00%	47 Missing ⚠️
lib/puppet/functions/stdlib/base64.rb	0.00%	46 Missing ⚠️
lib/puppet/functions/stdlib/validate_slength.rb	0.00%	44 Missing ⚠️
lib/puppet/functions/stdlib/values_at.rb	0.00%	44 Missing ⚠️
lib/puppet/functions/stdlib/has_interface_with.rb	0.00%	41 Missing ⚠️
lib/puppet/functions/stdlib/loadjson.rb	0.00%	41 Missing ⚠️
lib/puppet/functions/stdlib/loadyaml.rb	0.00%	41 Missing ⚠️
lib/puppet/functions/stdlib/range.rb	0.00%	40 Missing ⚠️
... and 126 more

Additional details and impacted files

@@            Coverage Diff            @@
##           master   #1079      +/-   ##
=========================================
- Coverage    4.54%   2.86%   -1.69%     
=========================================
  Files         183     319     +136     
  Lines        5238    8104    +2866     
=========================================
- Hits          238     232       -6     
- Misses       5000    7872    +2872     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.