Skip to content

(MODULES-10957) Override the set_sensitive_parameters method #1258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2021

Conversation

sheenaajay
Copy link
Contributor

Fix for the following warning message

Warning: /Postgresql_psql[ALTER ROLE testuser ENCRYPTED PASSWORD ****]: Unable to mark 'unless' as sensitive: unless is a parameter and not a property, and cannot be automatically redacted.

Override the set_sensitive_parameters method and mark the parameter as sensitive.

@puppet-community-rangefinder
Copy link

postgresql_psql is a type

Breaking changes to this file WILL impact these 8 modules (exact match):
Breaking changes to this file MAY impact these 8 modules (near match):

This module is declared in 70 of 576 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@codecov-io
Copy link

Codecov Report

Merging #1258 (769240b) into main (08e3a51) will increase coverage by 0.85%.
The diff coverage is 83.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1258      +/-   ##
==========================================
+ Coverage   65.81%   66.66%   +0.85%     
==========================================
  Files          14       14              
  Lines         351      354       +3     
==========================================
+ Hits          231      236       +5     
+ Misses        120      118       -2     
Impacted Files Coverage Δ
...ns/postgresql/postgresql_acls_to_resources_hash.rb 0.00% <0.00%> (ø)
...b/puppet/functions/postgresql/postgresql_escape.rb 0.00% <0.00%> (ø)
...puppet/functions/postgresql/postgresql_password.rb 0.00% <ø> (ø)
lib/puppet/functions/postgresql_escape.rb 0.00% <ø> (ø)
lib/puppet/functions/postgresql_password.rb 0.00% <ø> (ø)
lib/puppet/provider/postgresql_conf/parsed.rb 100.00% <ø> (ø)
.../puppet/provider/postgresql_conn_validator/ruby.rb 80.00% <ø> (ø)
lib/puppet/type/postgresql_conf.rb 93.33% <ø> (ø)
lib/puppet/type/postgresql_conn_validator.rb 100.00% <ø> (ø)
lib/puppet/type/postgresql_replication_slot.rb 100.00% <ø> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ced79c...769240b. Read the comment docs.

@sheenaajay
Copy link
Contributor Author

Centos8 timeout issues
https://tickets.puppetlabs.com/browse/IAC-1136

@sheenaajay sheenaajay marked this pull request as ready for review March 10, 2021 18:47
@sheenaajay sheenaajay requested a review from a team as a code owner March 10, 2021 18:47
@sanfrancrisko sanfrancrisko changed the title (MODULES-10957)override the set_sensitive_parameters method (MODULES-10957) Override the set_sensitive_parameters method Mar 12, 2021
@sanfrancrisko sanfrancrisko merged commit 37d25be into puppetlabs:main Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants