Fix warning introduced in #1240 (08a1752)

[smortex]

unless does not accept a Sensitive parameter, and passing one result in a warning being output:

(/Postgresql_psql[ALTER ROLE puppetdb ENCRYPTED PASSWORD ****]) Unable to mark 'unless' as sensitive: unless is a parameter and not a property, and cannot be automatically redacted.

This is not really an issue here since this query is not displayed in the logs, even in debug mode.

[puppet-community-rangefinder]

postgresql::server::role is a type

Breaking changes to this file WILL impact these 18 modules (exact match):

• nicopaez-dockerserver
• braiins-zabbix
• jjulien-trac
• landcareresearch-pidservice
• braiins-sentry
• nnutter-testdb
• Aethylred-gitlab
• nicopaez-alfred
• nicopaez-triage
• lwo-dataverse
• hetzner-roundcube
• maestrodev-maestro
• it2ndq-barman
• deric-barman
• npwalker-pe_external_postgresql
• groupbuddies-gb
• blackknight36-bacula
• landcareresearch-ckan

Breaking changes to this file MAY impact these 6 modules (near match):

• Firebladee-moodle
• tedivm-hieratic
• Aethylred-puppetdashboard
• puppetfinland-puppetmaster
• echoes-wrappers
• soli-wrappers

This module is declared in 71 of 576 indexed public Puppetfiles.

---

These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

[codecov-io]

Codecov Report

Merging #1249 (b999ea3) into main (08e3a51) will decrease coverage by 31.16%.
The diff coverage is 23.33%.

@@             Coverage Diff             @@
##             main    #1249       +/-   ##
===========================================
- Coverage   65.81%   34.64%   -31.17%     
===========================================
  Files          14       14               
  Lines         351      381       +30     
===========================================
- Hits          231      132       -99     
- Misses        120      249      +129     

Impacted Files	Coverage Δ
...ns/postgresql/postgresql_acls_to_resources_hash.rb	0.00% <0.00%> (ø)
...b/puppet/functions/postgresql/postgresql_escape.rb	0.00% <0.00%> (ø)
...puppet/functions/postgresql/postgresql_password.rb	0.00% <ø> (ø)
lib/puppet/functions/postgresql_escape.rb	0.00% <ø> (ø)
lib/puppet/functions/postgresql_password.rb	0.00% <ø> (ø)
lib/puppet/provider/postgresql_conf/parsed.rb	100.00% <ø> (ø)
.../puppet/provider/postgresql_conn_validator/ruby.rb	0.00% <ø> (-80.00%)	⬇️
...uppet/provider/postgresql_replication_slot/ruby.rb	37.93% <0.00%> (-37.94%)	⬇️
lib/puppet/type/postgresql_conf.rb	93.33% <ø> (ø)
lib/puppet/type/postgresql_conn_validator.rb	0.00% <ø> (-100.00%)	⬇️
... and 9 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 587fc12...b999ea3. Read the comment docs.

[smortex]

Cc authors of #1240 : @DavidS @sheenaajay

[sheenaajay]

@smortex Thanks alot for the quick fix.Much appreciated for your time.
Just wondering if we need a sanitisation mechanism to avoid shell injection for the values passed for username/password.

[ekohl]

Since that never was in place, perhaps this should be merged now to avoid the regression (warning). I can't think of a solution that does work.

[sheenaajay]

Thanks @ekohl and @smortex .Just had a quick discussion with team and we are looking into it. Will get the fix in. Thank you.

[sheenaajay]

Following ticket is opened for sensitive data support needed for unless command
https://tickets.puppetlabs.com/browse/PUP-10950. Thank you.

[sheenaajay]

Following changes added to fix the warning message. Thank you.
#1258

[smortex]

Replaced by #1258