Skip to content

Release v9.0.0 re-introduced Warning: ... Unable to mark 'unless' as sensitive #1432

Closed
@kBite

Description

@kBite

Describe the Bug

Commit db6f562a48f65229748b49ca87fec5015b0267dd in release v9.0.0 re-introduced Warning: ... Unable to mark 'unless' as sensitive reported in https://tickets.puppetlabs.com/browse/PUP-10950 and solved in #1258

Steps to Reproduce

With puppetlabs-postgresql v9.0.2 postgresql_psql type returns Warning:

Info: Loading facts
Warning: /Postgresql_psql[ALTER ROLE foreman ENCRYPTED PASSWORD ****]: Unable to mark 'unless' as sensitive: unless is a parameter and not a property, and cannot be automatically redacted.
Warning: /Postgresql_psql[ALTER ROLE puppetdb ENCRYPTED PASSWORD ****]: Unable to mark 'unless' as sensitive: unless is a parameter and not a property, and cannot be automatically redacted.
Info: Caching catalog for puppetserver.local
Info: Applying configuration version 'fb971897 (20 hours ago / 1683131057)'

Reverting commit db6f562a48f65229748b49ca87fec5015b0267dd postgresql_psql type returns without warning:

Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/type/postgresql_psql.rb]/content:
--- /opt/puppetlabs/puppet/cache/lib/puppet/type/postgresql_psql.rb     2023-05-04 12:05:30.862704153 +0000
+++ /tmp/puppet-file20230504-104293-7sdh7s      2023-05-04 12:07:14.192189033 +0000
@@ -148,7 +148,7 @@

   private

-  def sensitive_parameters=(sensitive_parameters)
+  def set_sensitive_parameters(sensitive_parameters)
     # Respect sensitive commands
     if sensitive_parameters.include?(:unless)
       sensitive_parameters.delete(:unless)

Notice: /File[/opt/puppetlabs/puppet/cache/lib/puppet/type/postgresql_psql.rb]/content: content changed '{sha256}4b6894e0a50955656a2f6b94f70fd40b7c6d4331f293935e8f87b8e5b0ac493a' to '{sha256}8f5a172419725d81c7967fe2342b16a1420511be119f71a512f32aa1d0568e02'
Info: Loading facts
Info: Caching catalog for puppetserver.local
Info: Applying configuration version 'fb971897 (20 hours ago / 1683131057)'

Additional Context

Other modules have disabled Naming/AccesorMethodName (e.g. https://github.com/puppetlabs/puppetlabs-yumrepo_core/blob/539670e92b7a38cd33c77d062fe6110e54b618b6/.rubocop.yml#L260)

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions