Skip to content

(#1432) - Fix Unable to mark 'unless' as sensitive #1433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

kBite
Copy link
Contributor

@kBite kBite commented May 4, 2023

disable 'Naming/AccessorMethodName' for 'set_sensitive_parameters'

disable 'Naming/AccessorMethodName' for 'set_sensitive_parameters'
@kBite kBite requested a review from a team as a code owner May 4, 2023 12:43
@CLAassistant
Copy link

CLAassistant commented May 4, 2023

CLA assistant check
All committers have signed the CLA.

@puppet-community-rangefinder
Copy link

postgresql_psql is a type

Breaking changes to this file WILL impact these 8 modules (exact match):
Breaking changes to this file MAY impact these 7 modules (near match):

This module is declared in 70 of 580 indexed public Puppetfiles.


These results were generated with Rangefinder, a tool that helps predict the downstream impact of breaking changes to elements used in Puppet modules. You can run this on the command line to get a full report.

Exact matches are those that we can positively identify via namespace and the declaring modules' metadata. Non-namespaced items, such as Puppet 3.x functions, will always be reported as near matches only.

@jordanbreen28
Copy link
Contributor

Nice job @kBite!
Thanks for picking up on my oversight...
Let's wait and see what happens with the CI, all being well I'll merge in right away.

Fixes #1432

Copy link
Collaborator

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly reverts db6f562 and applies a correct fix (disable RuboCop).

@kBite
Copy link
Contributor Author

kBite commented May 4, 2023

Thanks a lot 🙏

@jordanbreen28 jordanbreen28 merged commit 0b2b849 into puppetlabs:main May 4, 2023
@kBite kBite deleted the disable-naming-accessormethodname branch May 4, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v9.0.0 re-introduced Warning: ... Unable to mark 'unless' as sensitive
5 participants