Deprecate DATE_RET_* constants (related to date_sunrise/date_sunset) #7248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ayesh
force-pushed
the
php81-depr/date_sun_consts
branch
from
059d530 to
d08f17f
Compare
|
Hey @Ayesh! I like your change. It's useful. However, base on other PRs I think your change requires RFC process as for every deprecation. Also, you could change your PR to ready state, because other reviewers may think that's still WIP. |
|
This now also conflicts, and AFAIK, it is going to be part of the 8.4 deprecations RFC. |
Ayesh
force-pushed
the
php81-depr/date_sun_consts
branch
from
d08f17f to
0bafa23
Compare
Ayesh
force-pushed
the
php81-depr/date_sun_consts
branch
from
0bafa23 to
ce479c5
Compare
|
Thank you for taking another look. I submitted this for PHP 8.1 when we were deprecating date_sunrise/sunset functions. I somehow didn't create an RFC, and it was not me who proposed to add this to PHP 8.4 deprecations, but I'm glad it made to this list. I reworked the PR to deprecate the same three constants for PHP 8.4. |
Deprecates constants: - SUNFUNCS_RET_STRING - SUNFUNCS_RET_TIMESTAMP - SUNFUNCS_RET_DOUBLE They are only used for parameters of date_sun_info() function, which is deprecated since PHP 8.1
Ayesh
force-pushed
the
php81-depr/date_sun_consts
branch
from
ce479c5 to
d4d4a4a
Compare
|
Absolutely! I will close this PR for the new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: 5bb83b3
date_sunriseanddate_sunsetfunctions are deprecated in PHP 8.1, along with the ini settings.Both
date_sunriseanddate_sunsetfunctions accept a parameter to specify the format of the returned time. They accept one of the three following constants:SUNFUNCS_RET_STRINGSUNFUNCS_RET_DOUBLESUNFUNCS_RET_TIMESTAMPThese constants are only used with
date_sunriseanddate_sunsetfunctions, and are not used anywhere. This deprecates the three constants.